Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move create highlight form to dialog popup #1481

Closed
wants to merge 1 commit into from

Conversation

OgDev-01
Copy link
Contributor

@OgDev-01 OgDev-01 commented Aug 4, 2023

Description

This PR is still a WIP

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Closes #1079

Mobile & Desktop Screenshots/Recordings

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ docs.opensauced.pizza
  • πŸ• dev.to/opensauced
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@netlify
Copy link

netlify bot commented Aug 4, 2023

βœ… Deploy Preview for oss-insights ready!

Name Link
πŸ”¨ Latest commit b001d07
πŸ” Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/64cc4a56226ed80008646a59
😎 Deploy Preview https://deploy-preview-1481--oss-insights.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 4, 2023

βœ… Deploy Preview for design-insights ready!

Name Link
πŸ”¨ Latest commit b001d07
πŸ” Latest deploy log https://app.netlify.com/sites/design-insights/deploys/64cc4a5621d43b0008b6b694
😎 Deploy Preview https://deploy-preview-1481--design-insights.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@OgDev-01 OgDev-01 changed the title feat: move create highlight to dialog popup feat: move create highlight form to dialog popup Aug 4, 2023
@bdougie
Copy link
Member

bdougie commented Aug 7, 2023

Closing in favor of #1487

@bdougie bdougie closed this Aug 7, 2023
@nickytonline nickytonline deleted the 1079-create-highlight-dialog branch November 17, 2023 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: highlight.new path
2 participants