Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: highlight.new path #1079

Closed
1 of 2 tasks
bdougie opened this issue Apr 5, 2023 · 7 comments · Fixed by #1487
Closed
1 of 2 tasks

Feature: highlight.new path #1079

bdougie opened this issue Apr 5, 2023 · 7 comments · Fixed by #1487
Assignees
Labels
💡 feature high-priority Work on these issues first needs design Front-end tasks that are missing a design. Create a new issue for the design. released on @beta released

Comments

@bdougie
Copy link
Member

bdougie commented Apr 5, 2023

Type of feature

🍕 Feature

Current behavior

We own the highlight.new and got a note from the register. In order to compliant, we linking to the insights page.

Note from registry

Domain Name Non Compliant Policy
highlight.new Does not take the user directly into the action generation or content creation flow.

We would like to clarify that for highlight.new, the policy violation is due to the additional click "Create/Add insight Page" (see image 1) before entering the content creation flow. If the user is brought directly into the creation page screen (see image 2) after login, the website would be compliant.

Please update your website to be compliant with the above policy.

If the website is still not compliant in the next 14 days, your domain will be suspended. Suspended domains do not resolve, and cannot be transferred or deleted.

Regards,
Google Registry

Dear Registrant,

Google Registry conducts a weekly analysis of .new domains to verify compliance with our .new Registration Policies. On April 5, 2023, the following domain that you manage was determined non-compliant with the following policy:

Domain Name

Non Compliant Policy

highlight.new

Does not take the user directly into the action generation or content creation flow.

We would like to clarify that for highlight.new, the policy violation is due to the additional click "Create/Add insight Page" (see image 1) before entering the content creation flow. If the user is brought directly into the creation page screen (see image 2) after login, the website would be compliant.

Please update your website to be compliant with the above policy.

If the website is still not compliant in the next 14 days, your domain will be suspended. Suspended domains do not resolve, and cannot be transferred or deleted.

Regards,
Google Registry

Suggested solution

@getaheaddev need a highlights/new page.

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct

Contributing Docs

  • I agree to follow this project's Contribution Docs
@0-vortex
Copy link
Contributor

0-vortex commented Apr 5, 2023

14 days sounds like a deadline

IMG_2916

@bdougie
Copy link
Member Author

bdougie commented Apr 5, 2023

14 days sounds like a deadline

Correct, but we are in compliance now based on my redirect change to create an insight page. Ideally, we can get a design for the page next week and implement the UI the week after.

But to be clear, the solution doesn't need to be perfect, just work. We have not shared the existence of this URL outside of this issue.

@bdougie
Copy link
Member Author

bdougie commented Apr 6, 2023

Got confirmation via email that we are ow in compliance today.

I would still like this to redirect to a designed highlight creation page and not the current insight creation page.

@bdougie bdougie added the needs design Front-end tasks that are missing a design. Create a new issue for the design. label Apr 11, 2023
@getaheaddev
Copy link

Note to self: remove shopping cart look in the design

@bdougie
Copy link
Member Author

bdougie commented Aug 3, 2023

This route is currently broken and puts out at risk again per the above. @OgDev-01, can you do the following:

Create a new route for highlights to redirect to a highlight creation page. You can use the existing creation form, it just needs to force the user to authenticated if not already auth'd

@bdougie bdougie added the high-priority Work on these issues first label Aug 3, 2023
@bdougie bdougie changed the title Feature: highlight.new design Feature: highlight.new path Aug 3, 2023
@bdougie bdougie assigned diivi and unassigned OgDev-01 Aug 4, 2023
@open-sauced
Copy link
Contributor

open-sauced bot commented Aug 8, 2023

🎉 This issue has been resolved in version 1.59.0-beta.8 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@open-sauced
Copy link
Contributor

open-sauced bot commented Aug 8, 2023

🎉 This issue has been resolved in version 1.59.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@open-sauced open-sauced bot added the released label Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💡 feature high-priority Work on these issues first needs design Front-end tasks that are missing a design. Create a new issue for the design. released on @beta released
Projects
No open projects
7 participants