-
-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improve general responsiveness of the Highlights page #1361
Conversation
✅ Deploy Preview for oss-insights ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for design-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Compliance Checks Passed!
Hey @Shivam7-1, is this pr ready for review? I can still see the issue 👀 Let us know if you need any help 🙂 |
Hii PR is ready for review from my end. |
Hi @Shivam7-1, nothing has changed in with your PR though. Our expectation is stated below.
See #1336 (comment) as reference to better understand responsiveness. Do let us know if you need help or more clarity to implement this |
@Shivam7-1 are you still up for working on this PR? |
Hii I had Tried but haven't able to get expected result anyone else can good to go for this issue |
@Shivam7-1 no worries. Will close this one for now |
Description
This modification will ensure that the content inside the HighlightsFilterCard component is contained within an overflow container that allows horizontal scrolling when necessary and limits the maximum width to prevent overflow.
It will solve the General responsiveness of the Highlights page
What type of PR is this? (check all applicable)
Related Tickets & Documents
Fixes #1336
Mobile & Desktop Screenshots/Recordings
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?
7da9b438-1f16-4c87-8e70-9d525dccd390.mp4