Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve general responsiveness of the Highlights page #1361

Closed
wants to merge 1 commit into from
Closed

fix: improve general responsiveness of the Highlights page #1361

wants to merge 1 commit into from

Conversation

Shivam7-1
Copy link

@Shivam7-1 Shivam7-1 commented Jul 15, 2023

Description

This modification will ensure that the content inside the HighlightsFilterCard component is contained within an overflow container that allows horizontal scrolling when necessary and limits the maximum width to prevent overflow.

It will solve the General responsiveness of the Highlights page

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Fixes #1336

Mobile & Desktop Screenshots/Recordings

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 README.md
  • 📓 docs.opensauced.pizza
  • 🍕 dev.to/opensauced
  • 📕 storybook
  • 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

7da9b438-1f16-4c87-8e70-9d525dccd390.mp4

@netlify
Copy link

netlify bot commented Jul 15, 2023

Deploy Preview for oss-insights ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 540d711
🔍 Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/64b25adfe28d490008644b71
😎 Deploy Preview https://deploy-preview-1361--oss-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 15, 2023

Deploy Preview for design-insights ready!

Name Link
🔨 Latest commit 540d711
🔍 Latest deploy log https://app.netlify.com/sites/design-insights/deploys/64b25adf8411a60008983bd8
😎 Deploy Preview https://deploy-preview-1361--design-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

@Shivam7-1 Shivam7-1 changed the title Update index.tsx fix: improve general responsiveness of the Highlights page Jul 15, 2023
@takanome-dev
Copy link
Contributor

Hey @Shivam7-1, is this pr ready for review? I can still see the issue 👀

Let us know if you need any help 🙂

@Shivam7-1
Copy link
Author

Hey @Shivam7-1, is this pr ready for review? I can still see the issue eyes

Let us know if you need any help slightly_smiling_face

Hii PR is ready for review from my end.
Can I just get to know what issue is getting now as I attached End output of Code change

@babblebey
Copy link
Contributor

Hii PR is ready for review from my end. Can I just get to know what issue is getting now as I attached End output of Code change

Hi @Shivam7-1, nothing has changed in with your PR though.

Our expectation is stated below.

  • Avoid Horizontal Scroll Completely (This isn't good for mobile)
  • Hide Necessary components i.e. UserCard and HighlightsFilterCard at more appropriate breakpoints till you're left with only the Highlight Input Form and Highlights Lists as you scale down screen-size.

See #1336 (comment) as reference to better understand responsiveness.

Do let us know if you need help or more clarity to implement this

@bdougie
Copy link
Member

bdougie commented Jul 18, 2023

I think the ipad mini still presents an issue. Perhaps we remove right sidebar on anything that is not full width screen?

Screen Shot 2023-07-17 at 5 12 09 PM

@brandonroberts
Copy link
Contributor

@Shivam7-1 are you still up for working on this PR?

@Shivam7-1
Copy link
Author

@Shivam7-1 are you still up for working on this PR?

Hii I had Tried but haven't able to get expected result anyone else can good to go for this issue

@brandonroberts
Copy link
Contributor

@Shivam7-1 no worries. Will close this one for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: General Responsiveness of the Highlights Page
5 participants