-
-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improve general responsiveness of the Highlights page #1340
Conversation
β Deploy Preview for oss-insights ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
β Deploy Preview for design-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Compliance Checks Passed!
Hi @Shivam7-1 welcome to the community, could you check this specs, your title should be |
Hi @Shivam7-1, while you try to correct the PR title as stated by @NsdHSO, do add a before and after screenshots or screencast/video that demos the solution. |
Hi @babblebey , I was trying to run project locally but I wasn't able to run it locally and I also tried vs code but getting npm error can you please give me detailed steps should I perform to run project local system so that I can create Screen Recording |
Hey @Shivam7-1 I will assume you already have fork of the repo on your profile and it's cloned on your computer. Start by Updating this branch in your fork, and re-pull it onto your computer.
Then Follow the steps below.
That should be everything. Kindly Note: This Instruction assumes you already have NodeJS installed on your computer. If not, download NodeJS. |
Hii @babblebey I had Tryied above steps but i encountered Error After Performing Is There any solution Could you Recommend to Resolve above Error |
@Shivam7-1 what node version are you running. Can you share more details about your environment? |
Hii I am using VS Code editor and Node.js Latest LTS Version: 18.16.1 |
Linux? |
Windows 11 |
@Shivam7-1 run |
Hii I had Try after Re-install node.js again But Now i am getting this error I had attached Screen Recording of Error Can You please provide Solution if any |
Hi @Shivam7-1 This error is as a result of your Internet connectivity, do try again with a stronger internet connection. |
Hii @babblebey Thanks Now it worked and I am able to run locally |
Great stuff @Shivam7-1 Go on and do this! Do not forget to follow the current title structure when writing the title for your PR. In fact, I'd suggest that you just copy and use the current PR title as is for the new PR. Let's go βπΎ |
Yes done here it is #1361 |
What type of PR is this? (check all applicable)
Description
This modification will ensure that the content inside the HighlightsFilterCard component is contained within an overflow container that allows horizontal scrolling when necessary and limits the maximum width to prevent overflow.
It will solve the General responsiveness of the Highlights page.
Related Tickets & Documents
Fixes #1336
Mobile & Desktop Screenshots/Recordings
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?