Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add pull request velocity to user profile page #1215

Merged
merged 1 commit into from
May 23, 2023

Conversation

brandonroberts
Copy link
Contributor

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Description

  • Adds PR velocity to user profile page based on average open/closed time for recent merged pull requests
  • Adds test for the utility function

Closes #1201

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Screenshots are from prod data.

BEFORE:

image

AFTER:

image

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ docs.opensauced.pizza
  • πŸ• dev.to/opensauced
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@netlify
Copy link

netlify bot commented May 23, 2023

βœ… Deploy Preview for design-insights ready!

Name Link
πŸ”¨ Latest commit b5d2b5a
πŸ” Latest deploy log https://app.netlify.com/sites/design-insights/deploys/646cede603b8990008aff359
😎 Deploy Preview https://deploy-preview-1215--design-insights.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented May 23, 2023

βœ… Deploy Preview for oss-insights ready!

Name Link
πŸ”¨ Latest commit b5d2b5a
πŸ” Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/646cede69eab520007676eb6
😎 Deploy Preview https://deploy-preview-1215--oss-insights.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@bdougie bdougie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My one question is if we need to reuse this calculation everywhere (in the chrome extension) or should we the calculation to the API.

For now, let's merge though

@brandonroberts
Copy link
Contributor Author

Definitely worth revisiting there. Need to see impact on time to query the data for the user

@brandonroberts brandonroberts merged commit e458956 into beta May 23, 2023
@brandonroberts brandonroberts deleted the fix-contributor-pr-velocity branch May 23, 2023 17:03
github-actions bot pushed a commit that referenced this pull request May 23, 2023
## [1.48.0-beta.7](v1.48.0-beta.6...v1.48.0-beta.7) (2023-05-23)

### πŸ• Features

* add pull request velocity to user profile page ([#1215](#1215)) ([e458956](e458956))
@github-actions
Copy link
Contributor

πŸŽ‰ This PR is included in version 1.48.0-beta.7 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

github-actions bot pushed a commit that referenced this pull request May 23, 2023
## [1.48.0](v1.47.0...v1.48.0) (2023-05-23)

### πŸ” Continuous Integration

* move unit and e2e tests into separate jobs ([#1213](#1213)) ([d1ac6a0](d1ac6a0))

### πŸ› Bug Fixes

* check user follow after opening highlight menu ([#1197](#1197)) ([7ded9aa](7ded9aa))
* fix package.json merge ([287d999](287d999))
* fix repo overlap issue in Insight page ([#1204](#1204)) ([26f07b9](26f07b9))
* set default value to repo filter state ([#1214](#1214)) ([2f8b8d2](2f8b8d2))

### πŸ• Features

* add OpenGraph image for individual highlights ([#1205](#1205)) ([0e2b49f](0e2b49f))
* add Posthog as Next middleware ([#1210](#1210)) ([1f19b43](1f19b43))
* add pull request velocity to user profile page ([#1215](#1215)) ([e458956](e458956))
* Replace zendesk with SiteGPT ([#1209](#1209)) ([cb85a45](cb85a45))
@github-actions
Copy link
Contributor

πŸŽ‰ This PR is included in version 1.48.0 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

ElpisHelle added a commit to ElpisHelle/next.js-tailwindcss that referenced this pull request Aug 17, 2023
## [1.48.0-beta.7](open-sauced/app@v1.48.0-beta.6...v1.48.0-beta.7) (2023-05-23)

### πŸ• Features

* add pull request velocity to user profile page ([#1215](open-sauced/app#1215)) ([e458956](open-sauced/app@e458956))
ElpisHelle added a commit to ElpisHelle/next.js-tailwindcss that referenced this pull request Aug 17, 2023
## [1.48.0](open-sauced/app@v1.47.0...v1.48.0) (2023-05-23)

### πŸ” Continuous Integration

* move unit and e2e tests into separate jobs ([#1213](open-sauced/app#1213)) ([d1ac6a0](open-sauced/app@d1ac6a0))

### πŸ› Bug Fixes

* check user follow after opening highlight menu ([#1197](open-sauced/app#1197)) ([7ded9aa](open-sauced/app@7ded9aa))
* fix package.json merge ([287d999](open-sauced/app@287d999))
* fix repo overlap issue in Insight page ([#1204](open-sauced/app#1204)) ([26f07b9](open-sauced/app@26f07b9))
* set default value to repo filter state ([#1214](open-sauced/app#1214)) ([2f8b8d2](open-sauced/app@2f8b8d2))

### πŸ• Features

* add OpenGraph image for individual highlights ([#1205](open-sauced/app#1205)) ([0e2b49f](open-sauced/app@0e2b49f))
* add Posthog as Next middleware ([#1210](open-sauced/app#1210)) ([1f19b43](open-sauced/app@1f19b43))
* add pull request velocity to user profile page ([#1215](open-sauced/app#1215)) ([e458956](open-sauced/app@e458956))
* Replace zendesk with SiteGPT ([#1209](open-sauced/app#1209)) ([cb85a45](open-sauced/app@cb85a45))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: re-introduce PR velocity in user profile
3 participants