Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add PR velocity to profile page #109

Closed
bdougie opened this issue May 23, 2023 · 8 comments · Fixed by #111
Closed

feat: add PR velocity to profile page #109

bdougie opened this issue May 23, 2023 · 8 comments · Fixed by #111

Comments

@bdougie
Copy link
Member

bdougie commented May 23, 2023

It should follow this patter implemented here.

open-sauced/app#1215

image

@Nanak360
Copy link
Contributor

The API for this already exists if I am not wrong.
If so, I can take this up

@diivi
Copy link
Contributor

diivi commented May 23, 2023

There's no direct API, but if you get the contributor's Pull req data and follow the steps here - https://github.com/open-sauced/insights/pull/1215/files#diff-47eb3d1facb4c4bd6094c2c5e2d0ad0a8cab6e7dd086429a3347cc0ebd49b61a, it should be straightforward.

The endpoint is this one (for contributor PR data) - https://api.opensauced.pizza/#/User%20service/findContributorPullRequests

@bdougie
Copy link
Member Author

bdougie commented May 23, 2023

Yes. Though we will need a utility implemented similar to lib/utils/get-contributor-pr-velocity.ts in that PR

@Nanak360
Copy link
Contributor

Yup makes sense
Seems straightforward as well
We already have one example for getting PR velocity
Just have to encapsulate it as a util function

@Nanak360
Copy link
Contributor

There's no direct API, but if you get the contributor's Pull req data and follow the steps here - https://github.com/open-sauced/insights/pull/1215/files#diff-47eb3d1facb4c4bd6094c2c5e2d0ad0a8cab6e7dd086429a3347cc0ebd49b61a, it should be straightforward.

The endpoint is this one (for contributor PR data) - https://api.opensauced.pizza/#/User%20service/findContributorPullRequests

This implementation of PR velocity has prsMergedPercentage information as well.
image
Should that be added as well?

@bdougie
Copy link
Member Author

bdougie commented May 23, 2023

Should that be added as well?

No, not needed

@github-actions
Copy link

🎉 This issue has been resolved in version 1.2.0-beta.7 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This issue has been resolved in version 1.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants