fix: Removes NewsletterForm usage in favor of sole link to newsletter #3897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for oss-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for design-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
brandonroberts
approved these changes
Aug 8, 2024
Signed-off-by: John McBride <[email protected]>
|
Applied the same feedback from open-sauced/landing-page#337 (comment) here: now the
|
nickytonline
approved these changes
Aug 8, 2024
open-sauced bot
pushed a commit
that referenced
this pull request
Aug 8, 2024
## [2.52.0-beta.10](v2.52.0-beta.9...v2.52.0-beta.10) (2024-08-08) ### 🐛 Bug Fixes * Removes NewsletterForm usage in favor of sole link to newsletter ([#3897](#3897)) ([61951ff](61951ff))
open-sauced bot
pushed a commit
that referenced
this pull request
Aug 9, 2024
## [2.52.0](v2.51.0...v2.52.0) (2024-08-09) ### 🍕 Features * add OSCR tooltip to user page ([#3857](#3857)) ([fd5fa41](fd5fa41)) * add OSCR's location to PostHog capture ([#3895](#3895)) ([bbf8ee5](bbf8ee5)) * now OSCR appears on repository page contributor grid view ([#3884](#3884)) ([d7163d8](d7163d8)) * repository page contributor graph defaults to enhance by default now ([#3880](#3880)) ([90948a5](90948a5)) * tracking DevCard analytics ([#3874](#3874)) ([583e42a](583e42a)) ### 🐛 Bug Fixes * calculate avergage per week for ross contributors greater than 0 ([#3893](#3893)) ([a8859c5](a8859c5)) * excluded OSCR from old contributor card list component ([#3901](#3901)) ([446f27c](446f27c)) * now layout toggles are radio buttons ([#3888](#3888)) ([efba1f8](efba1f8)) * now the contributor card user profile link no longer affects the OSCR login flow ([#3898](#3898)) ([7405660](7405660)) * now the contributor scatter chart toggle group has a label ([#3882](#3882)) ([adf5c6c](adf5c6c)) * Removes NewsletterForm usage in favor of sole link to newsletter ([#3897](#3897)) ([61951ff](61951ff)) * repository insight limited features ([#3876](#3876)) ([5ef6bd6](5ef6bd6)) * show loading indicator for contributor confidence if undefined ([#3894](#3894)) ([3032a6a](3032a6a)) * update profile interests type to be optional and add guards ([#3890](#3890)) ([2e62773](2e62773))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the usage of
NewsletterFormin favor ofNewsletterLinkwhich is just a sole button that shims to our ghost.io newsletter subscribe page.Related Tickets & Documents
Closes: #3796Quickfix for: #3796Mobile & Desktop Screenshots/Recordings
Steps to QA
Tier (staff will fill in)