Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: now OSCR appears on repository page contributor grid view #3884

Merged

Conversation

nickytonline
Copy link
Member

@nickytonline nickytonline commented Aug 7, 2024

Description

Now the OSCR appears on the repository page contributor grid view.

Related Tickets & Documents

Closes #3883

Mobile & Desktop Screenshots/Recordings

Before

CleanShot 2024-08-07 at 16 56 20

After

CleanShot 2024-08-07 at 22 13 27

Steps to QA

Logged Out

  1. Go to any repository contributor page, e.g. http://localhost:3000/s/denoland/deno/contributors?range=30
  2. Notice the grid view (default view) displays OSCRs with the lock button for contributors.
  3. Log in.
  4. Notice the grid view (default view) displays OSCRs for contributors.

Logged In

  1. Go to any repository contributor page, e.g. http://localhost:3000/s/denoland/deno/contributors?range=30
  2. Notice the grid view (default view) displays OSCRs for contributors.

Tier (staff will fill in)

  • Tier 1
  • Tier 2
  • Tier 3
  • Tier 4

[optional] What gif best describes this PR or how it makes you feel?

Copy link

netlify bot commented Aug 7, 2024

Deploy Preview for oss-insights ready!

Name Link
🔨 Latest commit c9a67e4
🔍 Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/66b42a3d20587d00081a123f
😎 Deploy Preview https://deploy-preview-3884--oss-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Aug 7, 2024

Deploy Preview for design-insights ready!

Name Link
🔨 Latest commit c9a67e4
🔍 Latest deploy log https://app.netlify.com/sites/design-insights/deploys/66b42a3d12c486000881989d
😎 Deploy Preview https://deploy-preview-3884--design-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nickytonline nickytonline marked this pull request as draft August 7, 2024 21:06
@nickytonline nickytonline force-pushed the nickytonline/oscr-grid-view-repo-contributor-page branch from 50cebca to 814ff02 Compare August 7, 2024 21:19
@nickytonline nickytonline marked this pull request as ready for review August 7, 2024 21:36
@nickytonline nickytonline requested review from BekahHW and a team August 7, 2024 22:06
Copy link
Member

@jpmcb jpmcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome: way to turn this around so quickly. Let me know if you need anything on the API!

@nickytonline
Copy link
Member Author

Looks awesome: way to turn this around so quickly. Let me know if you need anything on the API!

Thanks John! I’ll make the small changes in the API. It’s just returning an updated_at for the endpoint getting repo contributor data.

Copy link
Contributor

@brandonroberts brandonroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nickytonline nickytonline merged commit d7163d8 into beta Aug 8, 2024
25 checks passed
@nickytonline nickytonline deleted the nickytonline/oscr-grid-view-repo-contributor-page branch August 8, 2024 12:30
open-sauced bot pushed a commit that referenced this pull request Aug 8, 2024
## [2.52.0-beta.3](v2.52.0-beta.2...v2.52.0-beta.3) (2024-08-08)

### 🍕 Features

* now OSCR appears on repository page contributor grid view ([#3884](#3884)) ([d7163d8](d7163d8))
open-sauced bot pushed a commit that referenced this pull request Aug 9, 2024
## [2.52.0](v2.51.0...v2.52.0) (2024-08-09)

### 🍕 Features

* add OSCR tooltip to user page ([#3857](#3857)) ([fd5fa41](fd5fa41))
* add OSCR's location to PostHog capture ([#3895](#3895)) ([bbf8ee5](bbf8ee5))
* now OSCR appears on repository page contributor grid view ([#3884](#3884)) ([d7163d8](d7163d8))
* repository page contributor graph defaults to enhance by default now ([#3880](#3880)) ([90948a5](90948a5))
* tracking DevCard analytics ([#3874](#3874)) ([583e42a](583e42a))

### 🐛 Bug Fixes

* calculate avergage per week for ross contributors greater than 0 ([#3893](#3893)) ([a8859c5](a8859c5))
* excluded OSCR from old contributor card list component ([#3901](#3901)) ([446f27c](446f27c))
* now layout toggles are radio buttons ([#3888](#3888)) ([efba1f8](efba1f8))
* now the contributor card user profile link no longer affects the OSCR login flow ([#3898](#3898)) ([7405660](7405660))
* now the contributor scatter chart toggle group has a label ([#3882](#3882)) ([adf5c6c](adf5c6c))
* Removes NewsletterForm usage in favor of sole link to newsletter ([#3897](#3897)) ([61951ff](61951ff))
* repository insight limited features ([#3876](#3876)) ([5ef6bd6](5ef6bd6))
* show loading indicator for contributor confidence if undefined ([#3894](#3894)) ([3032a6a](3032a6a))
* update profile interests type to be optional and add guards ([#3890](#3890)) ([2e62773](2e62773))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Add OSCR to repository page contributor grid view
3 participants