Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: linkedin projects share #264

Merged
merged 2 commits into from
Sep 18, 2023
Merged

fix: linkedin projects share #264

merged 2 commits into from
Sep 18, 2023

Conversation

Anush008
Copy link
Member

@Anush008 Anush008 commented Sep 2, 2023

Description

This PR fixes the infamous and long-overdue #221 by delegating the injection task to a background worker. As the current implementation using the button's onClick handler breaks up abruptly, causing the issue.

Additionally, adds a popover attribute to the AI PR description button for #254.

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Resolves #254.
Resolves #221.

Mobile & Desktop Screenshots/Recordings

Untitled2-2

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 README.md
  • 📓 docs.opensauced.pizza
  • 🍕 dev.to/opensauced
  • 📕 storybook
  • 🙅 no documentation needed

Copy link
Member

@bdougie bdougie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry. Meant to approve this last week.

@bdougie bdougie merged commit 481472b into beta Sep 18, 2023
github-actions bot pushed a commit that referenced this pull request Sep 18, 2023
## [1.14.1-beta.4](v1.14.1-beta.3...v1.14.1-beta.4) (2023-09-18)

### 🐛 Bug Fixes

* linkedin projects share ([#264](#264)) ([481472b](481472b))
@github-actions
Copy link

🎉 This PR is included in version 1.14.1-beta.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@Anush008 Anush008 deleted the fix-linkedin branch September 18, 2023 13:19
github-actions bot pushed a commit that referenced this pull request Nov 1, 2023
## [1.14.1](v1.14.0...v1.14.1) (2023-11-01)

### ✅ Tests

* setup playwright for e2e testing ([#262](#262)) ([fc9acca](fc9acca))

### 🔁 Continuous Integration

* bun install, x ([#265](#265)) ([6c765e0](6c765e0))

### 🐛 Bug Fixes

* linkedin projects share ([#264](#264)) ([481472b](481472b))
* login to the website after rename ([1070a0c](1070a0c))
* prevent error when viewing repo and not logged in ([#260](#260)) ([05fcf5e](05fcf5e))
* syntax error being thrown in Firefox for anonymous objects with computed property names ([#241](#241)) ([00ba2c8](00ba2c8))
Copy link

github-actions bot commented Nov 1, 2023

🎉 This PR is included in version 1.14.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants