Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent error when viewing repo and not logged in #260

Conversation

marcusgchan
Copy link
Contributor

Description

Added optional chaining operator to prevent extension from throwing an error when not logged in and viewing a repo (when color_mode cookie is not set).

Fixes #240

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

#240

Mobile & Desktop Screenshots/Recordings

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 README.md
  • 📓 docs.opensauced.pizza
  • 🍕 dev.to/opensauced
  • 📕 storybook
  • 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@marcusgchan marcusgchan marked this pull request as ready for review August 21, 2023 03:04
Copy link
Member

@Anush008 Anush008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 👍🚀

@bdougie bdougie merged commit 05fcf5e into open-sauced:beta Aug 22, 2023
github-actions bot pushed a commit that referenced this pull request Aug 22, 2023
## [1.14.1-beta.2](v1.14.1-beta.1...v1.14.1-beta.2) (2023-08-22)

### 🐛 Bug Fixes

* prevent error when viewing repo and not logged in ([#260](#260)) ([05fcf5e](05fcf5e))
@github-actions
Copy link

🎉 This PR is included in version 1.14.1-beta.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this pull request Nov 1, 2023
## [1.14.1](v1.14.0...v1.14.1) (2023-11-01)

### ✅ Tests

* setup playwright for e2e testing ([#262](#262)) ([fc9acca](fc9acca))

### 🔁 Continuous Integration

* bun install, x ([#265](#265)) ([6c765e0](6c765e0))

### 🐛 Bug Fixes

* linkedin projects share ([#264](#264)) ([481472b](481472b))
* login to the website after rename ([1070a0c](1070a0c))
* prevent error when viewing repo and not logged in ([#260](#260)) ([05fcf5e](05fcf5e))
* syntax error being thrown in Firefox for anonymous objects with computed property names ([#241](#241)) ([00ba2c8](00ba2c8))
Copy link

github-actions bot commented Nov 1, 2023

🎉 This PR is included in version 1.14.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Extension throws an error when setting color preference if user is not logged in to GitHub
3 participants