-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: updated link #245
fix: updated link #245
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Compliance Checks Passed!
@CBID2 need to run |
Ohh ok |
src/content-scripts/components/AddPRToHighlights/AddPRToHighlightsButton.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a comment for what is expected.
src/content-scripts/components/AddPRToHighlights/AddPRToHighlightsButton.ts
Outdated
Show resolved
Hide resolved
…ghtsButton.ts Co-authored-by: Brian Douglas <[email protected]>
Did it @bdougie |
## [1.14.0-beta.2](v1.14.0-beta.1...v1.14.0-beta.2) (2023-08-15) ### 🐛 Bug Fixes * updated link ([#245](#245)) ([fe1a58b](fe1a58b))
🎉 This PR is included in version 1.14.0-beta.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 1.14.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Description
This PR updates the
AddPRToHighlightsButton
component in theAddPRToHighlightsButton.ts
file.onclick
event handler has been updated to toggle the visibility of the dropdown menu.addEventListener
for theclick
event has been added to hide the dropdown menu when clicking outside of it.These changes improve the functionality and user experience of the
AddPRToHighlightsButton
component.What type of PR is this? (check all applicable)
Related Tickets & Documents
Fixes #242
Mobile & Desktop Screenshots/Recordings
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?