Bug: PR does not automatically go to Highlights

[CBID2]

Describe the bug

Whenever I click on "Add PR to highlights" to place a merged PR in that section, it goes there, but the chosen PR does not automatically appear there.

Steps to reproduce

1. Sign in to the Chrome Extension
2. Go to a merged PR
3. Click on the OpenSauced icon
4. Click on the Add PR to the Highlights section

Browsers

Chrome

Additional context (Is this in dev or production?)

Adding.Video.subcategory.and.resource.for.the.open.source.section.by.CBID2.Pull.Request.1494.rupali-codes_LinksHub.-.8.August.2023.mp4

Code of Conduct

• I agree to follow this project's Code of Conduct

Contributing Docs

• I agree to follow this project's Contribution Docs

[Anush008]

@CBID2, can you share the link to the PR that's not working for you?

[diivi]

We just redirect to the highlights page right now if I remember correctly. No information is auto filled for now.

[Anush008]

It's about the 'Post a highlight' autofill I think.

[CBID2]

It's about the 'Post a highlight' autofill I think.

Yeah that's the one

[CBID2]

@CBID2, can you share the link to the PR that's not working for you?

It's a issue I have with all my PRs.

[Anush008]

I tried posting a highlight. The auto-fill worked for me as expected. Can you share a recording?

[bdougie]

Was it a draft PR @CBID2?

[CBID2]

Was it a draft PR @CBID2?

No a merged one @bdougie

[CBID2]

I tried posting a highlight. The auto-fill worked for me as expected. Can you share a recording?

Yup, just posted one in the Additional information section of the issue @Anush008. Feel free to check it out too @bdougie

[bdougie]

We need to change this altogether. This PR open-sauced/app#1487 changes how we will link to highlighting creation moving forward.

I suggest fixing the links to https://highlight.new and passing in query params to populate the opened input.

[Anush008]

Just saw the recording. I thought it was about posting a highlight from the extension's pop-up page which has auto-fill.

[CBID2]

We need to change this altogether. This PR open-sauced/app#1487 changes how we will link to highlighting creation moving forward.

I suggest fixing the links to https://highlight.new and passing in query params to populate the opened input.

Okay where can I do that as far as files or folders @bdougie?

[bdougie]

Start with search in the repo for the copy, "add to highlight"

[CBID2]

Start with search in the repo for the copy, "add to highlight"

Is it this one @bdougie: https://github.com/open-sauced/ai/blob/beta/src/utils/dom-utils/addPRToHighlights.ts
Or these two?

https://github.com/open-sauced/ai/tree/beta/src/content-scripts/components/AddPRToHighlights

https://github.com/open-sauced/ai/blob/beta/src/content-scripts/components/AddPRToHighlights/AddPRToHighlightsButton.ts

[Anush008]

@CBID2, https://github.com/open-sauced/ai/blob/beta/src/utils/dom-utils/addPRToHighlights.ts handles adding the button to GitHub.

https://github.com/open-sauced/ai/blob/beta/src/content-scripts/components/AddPRToHighlights/AddPRToHighlightsButton.ts controls the button behaviour. Your changes need to go here.

[CBID2]

@CBID2, https://github.com/open-sauced/ai/blob/beta/src/utils/dom-utils/addPRToHighlights.ts handles adding the button to GitHub.

https://github.com/open-sauced/ai/blob/beta/src/content-scripts/components/AddPRToHighlights/AddPRToHighlightsButton.ts controls the button behaviour. Your changes need to go here.

Thanks @Anush008

[github-actions]

🎉 This issue has been resolved in version 1.14.0-beta.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[github-actions]

🎉 This issue has been resolved in version 1.14.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀