fix: incorrect embedding status, regex security warnings #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anush008
changed the title
diivi
approved these changes
Aug 11, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Aug 11, 2023
## [1.13.1-beta.1](v1.13.0...v1.13.1-beta.1) (2023-08-11) ### 🐛 Bug Fixes * incorrect embedding status, regex security warnings ([#253](#253)) ([34f66b1](34f66b1))
|
🎉 This PR is included in version 1.13.1-beta.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.14.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug in
IndexingPagewhere thereadervariable was incorrectly assigned toresponse.body?.getReader(). It should be assigned toembedResponse.body?.getReader()instead.Generated using OpenSauced.
Additionally, adds minor updates to the URL matchers to resolve the regex security warnings.
What type of PR is this? (check all applicable)
Related Tickets & Documents
Fixes #252.
Resolves the following warnings.
#246, #247, #248.
Mobile & Desktop Screenshots/Recordings
Added tests?
Added to documentation?