-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix README.md to work with Doxygen release 1.10.0 #1775
Conversation
Looks good to me. :) Thanks for this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of this, @praveksharma!
@Martyrshot I forgot to mark the draft PR to ready for review, sorry about that. Merging is blocked till the changes get another approval. |
If we were to rename the section title from |
I considered that. Since both |
Okay... would |
Signed-off-by: Pravek Sharma <[email protected]>
Signed-off-by: Pravek Sharma <[email protected]>
Signed-off-by: Pravek Sharma <[email protected]>
Signed-off-by: Pravek Sharma <[email protected]>
Either would work, I ended up going with |
I pushed some more changes: the CI needed to be tweaked a little once the CI containers started using the updated images from openquantumsafe/ci-containers#76. CI now uses |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# The default value is: DOXYGEN. | ||
# This tag requires that the tag MARKDOWN_SUPPORT is set to YES. | ||
|
||
MARKDOWN_ID_STYLE = DOXYGEN |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment seems to suggest a new feature controlling how anchors for headers are generated for Markdown files. Would this have solved our problem?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it might. I'll merge this so PRs with red CI can rebase to main and create a new PR to address configuring Doxygen more appropriately if that is applicable.
* fix link in README.md Signed-off-by: Pravek Sharma <[email protected]> * simplify linux and mac link in README.md Signed-off-by: Pravek Sharma <[email protected]> * update Doxyfile Signed-off-by: Pravek Sharma <[email protected]> * update CI to use /scripts/run_doxygen.sh Signed-off-by: Pravek Sharma <[email protected]> --------- Signed-off-by: Pravek Sharma <[email protected]>
Undoes changes from #1769 and re-introduces changes from #1715 to satisfy Doxygen release 1.10.0.
GitHub markdown provides a few extension in addition to the standard Markdown spec; a valid GitHub Markdown file isn't necessarily a valid Markdown file (see this comment by a Doxygen contributer). Changing
#linuxmacos
to either#linuxmacOS
or#linux/macOS
worked for me locally; I chose#linuxmacOS
because that seems to keep the link intact at the moment.CI containers currently use Doxygen 1.9.2, openquantumsafe/ci-containers#76 updates them to use Doxygen 1.10.0.