Errors not printed out when OPENSSL_NO_STDIO is set #1774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bencemali
force-pushed
the
openssl_no_stdio
branch
from
e5ba471
to
1e4b92d
Compare
baentsch
approved these changes
May 8, 2024
There was a problem hiding this comment.
Looks sensible to me. Thanks for the improved guard, @bencemali !
|
Please rebase as the current CI error should be fixed as #1775 landed. |
dstebila
approved these changes
May 8, 2024
SWilson4
approved these changes
May 10, 2024
Signed-off-by: Bence Mali <[email protected]>
bencemali
force-pushed
the
openssl_no_stdio
branch
from
1e4b92d
to
ae8511d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The handleErrors function should print out errors when OPENSSL_NO_STDIO is set. The ERR_clear_error function is called instead since ERR_print_errors_fp would empty the error queue.