-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renamed ApplicationStartInfo and its components #6
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm confused as to how this has changes to go.sum
without any corresponding changes to go.mod
. It also appears to remove go.opentelemetry.io/collector
completely from go.sum
. Shouldn't it need to update that dependency to a newer version to obtain the component.BuildInfo
type?
Yes, I will do that and update the |
Yes, all of the dependencies should be updated to versions that include the required functionality.
I think that it can probably be done in a single PR, but I would suggest sequencing your commits such that they can be separated should the upstream maintainers ask for separate PRs. |
There are already PRs in the upstream aws-otel-collector to bump the version of the So I will create a new branch and PR to bump the version of awsprometheusremotewriteexporter of opentelemetry-collector-contrib repo. |
This PR is stale because it has been open 30 days with no activity. |
This PR is stale because it has been open 30 days with no activity. |
Description:
In order to align with the changes in the OpenTelemetry-Collector, the following changes have been made:
References: #3056, #3057, #3275