Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed ApplicationStartInfo and its components #6

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

dhruv-vora
Copy link

@dhruv-vora dhruv-vora commented May 10, 2021

Description:
In order to align with the changes in the OpenTelemetry-Collector, the following changes have been made:

  • Renamed ApplicationStartInfo to BuildInfo
  • Renamed ExeName to Command
  • Renamed LongName to Description
  • Removed GitHash

References: #3056, #3057, #3275

Copy link

@Aneurysm9 Aneurysm9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused as to how this has changes to go.sum without any corresponding changes to go.mod. It also appears to remove go.opentelemetry.io/collector completely from go.sum. Shouldn't it need to update that dependency to a newer version to obtain the component.BuildInfo type?

@dhruv-vora
Copy link
Author

Yes, I will do that and update the go.opentelemetry.io/collector to v0.26.1-0.20210506153408-a4bc949ebcdc. (version which the Collector-Contrib also uses)
The OpenTelemetry-Collector-Contrib has also been updated to v0.26.0. So should I update the versions of all the corresponding components too?
If so, should I create a new branch and PR for updating the versions or do it in this itself?

@Aneurysm9
Copy link

Yes, I will do that and update the go.opentelemetry.io/collector to v0.26.1-0.20210506153408-a4bc949ebcdc. (version which the Collector-Contrib also uses)
The OpenTelemetry-Collector-Contrib has also been updated to v0.26.0. So should I update the versions of all the corresponding components too?

Yes, all of the dependencies should be updated to versions that include the required functionality.

If so, should I create a new branch and PR for updating the versions or do it in this itself?

I think that it can probably be done in a single PR, but I would suggest sequencing your commits such that they can be separated should the upstream maintainers ask for separate PRs.

@dhruv-vora
Copy link
Author

dhruv-vora commented May 11, 2021

There are already PRs in the upstream aws-otel-collector to bump the version of the go.opentelemetry.io/collector to v0.26.0 and also to bump the version of some of the other components of the opentelemetry-collector-contrib.

So I will create a new branch and PR to bump the version of awsprometheusremotewriteexporter of opentelemetry-collector-contrib repo.

@dhruv-vora dhruv-vora requested a review from Aneurysm9 May 11, 2021 01:05
@github-actions
Copy link

This PR is stale because it has been open 30 days with no activity.

@github-actions github-actions bot added the stale label Nov 14, 2021
@github-actions github-actions bot removed the stale label Jul 31, 2022
@github-actions
Copy link

github-actions bot commented Sep 4, 2022

This PR is stale because it has been open 30 days with no activity.

@github-actions github-actions bot added the stale label Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants