Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated usage of ApplicationStartInfo to BuildInfo #3275

Merged
merged 7 commits into from
Apr 30, 2021
Merged

Updated usage of ApplicationStartInfo to BuildInfo #3275

merged 7 commits into from
Apr 30, 2021

Conversation

dhruv-vora
Copy link
Contributor

@dhruv-vora dhruv-vora commented Apr 28, 2021 •
edited
Loading

Description:

  • Changed usage of ApplicationStartInfo to BuildInfo
  • Changed ExeName to Command

This is in continuation to open-telemetry/opentelemetry-collector/pull/3056 and open-telemetry/opentelemetry-collector/pull/3057

@dhruv-vora dhruv-vora requested a review from a team April 28, 2021 20:22
@dhruv-vora
Copy link
Contributor Author

/cc @bogdandrutu @Aneurysm9 @anuraaga

mxiamxia
mxiamxia approved these changes Apr 29, 2021
View reviewed changes
Copy link
Member

@mxiamxia mxiamxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after addressing the comments.

@dhruv-vora dhruv-vora changed the title Updated usage of ApplicationStartInfo to BinaryInfo Updated usage of ApplicationStartInfo to BuildInfo Apr 29, 2021
@bogdandrutu
Copy link
Member

please run make update-otel

@dhruv-vora dhruv-vora force-pushed the update-application-start-info branch from e486aa7 to efaeb73 Compare April 29, 2021 23:54
@dhruv-vora dhruv-vora force-pushed the update-application-start-info branch from 26c3f3f to 36b691a Compare April 30, 2021 18:04
@bogdandrutu
Copy link
Member

Please fix lint errors (to run locally make golint)

newrelic.go:41: File is not `gofmt`-ed with `-s` (gofmt)
	buildInfo     *component.BuildInfo
make[1]: *** [../../Makefile.Common:93: lint] Error 1

@bogdandrutu bogdandrutu merged commit 64a5d55 into open-telemetry:main Apr 30, 2021
@dhruv-vora dhruv-vora mentioned this pull request May 10, 2021
Open
@dhruv-vora dhruv-vora mentioned this pull request May 11, 2021
Closed
alexperez52 referenced this pull request in open-o11y/opentelemetry-collector-contrib Aug 18, 2021
@sethAmazon
Add Error Writer For File Exporter Tests And Remove Limited Writer #3225
35f0d0e 
 (#3275)

Error Writer Is Internal To File Exporter Test And Will No Be Apart Of Test Util Like Limited Writer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxiamxia mxiamxia mxiamxia approved these changes

@bogdandrutu bogdandrutu bogdandrutu approved these changes

@Aneurysm9 Aneurysm9 Aneurysm9 approved these changes

@anuraaga anuraaga Awaiting requested review from anuraaga

@jpkrohling jpkrohling Awaiting requested review from jpkrohling jpkrohling is a code owner

@kbrockhoff kbrockhoff Awaiting requested review from kbrockhoff

@arminru arminru Awaiting requested review from arminru

@djaglowski djaglowski Awaiting requested review from djaglowski djaglowski is a code owner

@dmitryax dmitryax Awaiting requested review from dmitryax dmitryax is a code owner

@jmacd jmacd Awaiting requested review from jmacd jmacd is a code owner

@jrcamp jrcamp Awaiting requested review from jrcamp

@owais owais Awaiting requested review from owais

Assignees

@owais owais

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dhruv-vora @bogdandrutu @Aneurysm9 @mxiamxia @owais