Error on usage of removed symbols without --enable-mpi1-compatibility configure flag. #6281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) Corretly updates IBM Copyrights on files changes in PR6120 2) Added an intentional C syntax error in mpi.h.in to cause an error on usage of a removed API, while still printing a useful error message for MPI users.
|
I'm still testing, but posting for review. We need to discuss what solution we want for master, as this was targeted as a fix on top of PR#6120 for v4.0.x only. |
|
This is one possible solution to #6278. |
gpaulsen
changed the title
|
Per discussion on the 2019-01-15 webex, @gpaulsen will update this PR per #6278 (comment) |
|
Closing in favor of #6359 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
error on usage of a removed API, while still printing a
useful error message for MPI users.