Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "v4.0.x: Re-add removed deprecate-only MPI-2.0 symbols" #6268

Closed

Conversation

gpaulsen
Copy link
Member

Reverts #6120

@hppritcha hppritcha added this to the v4.0.1 milestone Jan 14, 2019
@gpaulsen
Copy link
Member Author

#6120 was not quite ready to go into v4.0.x

In my testing I found that while it was correctly warning of removed symbols when configured without --enable-mpi1-compatability, it SHOULD have been a fatal build error, rather than just a warning.

After we revert this, I'll push the newer code which fixes this.

This PR has a bit of an issue in that I hit the revert button in github to create this PR, but that does not "sign-off" the Commit, which our Signed-off-by-checker then yells about.

I'll bring up on today's RM meeting.

@jsquyres
Copy link
Member

@gpaulsen and I talked about this on the phone today. Let's just close this PR without merging; @gpaulsen is going to open a new PR in the immediate future with the corrections to #6120 and the additional fix that is required.

@jsquyres jsquyres closed this Jan 14, 2019
@jsquyres jsquyres deleted the revert-6120-topic/v4.0.x/re-add-deprecated-oops branch January 14, 2019 20:36
@gpaulsen
Copy link
Member Author

New PR is: #6281

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants