Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add HRViT (CVPR'2022) #1736

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lorinczszabolcs
Copy link

@lorinczszabolcs lorinczszabolcs commented Jul 4, 2022

Motivation

Add HRViT (resolve #1730) described in "Multi-Scale High-Resolution Vision Transformer for Semantic Segmentation" which is a new vision transformer backbone design for semantic segmentation. It has a multi-branch high-resolution (HR) architecture with enhanced multi-scale representability, surpassing state-of-the-art MiT and CSWin backbones with an average of +1.78 mIoU improvement, 28% parameter saving, and 21% FLOPs reduction on ADE20K and Cityscapes.

Modification

New HRViT backbone and sample config files are added.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues. ✅
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness. ❌ - need to add them later, might need some help
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMDet3D. - ❗ - not sure if it applies, but this backbone could be used in MMDet potentially as well.
  4. The documentation has been modified accordingly, like docstring or example tutorials. ❌ - need to add documentation and docstrings later on

Notes about LICENSE:

Implementation mostly borrowed from the original repository with slight modifications to make it compatible with mmsegmentation, kept the copyright notices in the files.

@CLAassistant
Copy link

CLAassistant commented Jul 4, 2022

CLA assistant check
All committers have signed the CLA.

@lorinczszabolcs lorinczszabolcs changed the title Initial implementation of HRViT [Feature] Add HRViT (CVPR'2022) Jul 4, 2022
@xiexinch
Copy link
Collaborator

xiexinch commented Jul 4, 2022

Hi @lorinczszabolcs
Thanks for your nice PR! Since the official repo doesn't release the pretrained weights, facebookresearch/HRViT#3, after discussion, we are considering to temporarily pending this PR. But we will continuously follow the work of HRViT, if there is release pretrain, we will continue to promote this PR, if you find HRViT author released pretrain, you can also come to this pr to leave a message.
And if you don't mind, you could then follow the contribution guide to fix the lint error.

@lorinczszabolcs
Copy link
Author

Hi @xiexinch !

Ok, it's understandable, hopefully they will release pretrained weights soon.

I followed the contribution guide, and used the pre-commit hooks as well, but didn't add docstrings yet in case if there would be changes to the code itself, that is why linting failed. In case if the PR will go ahead upon release of pretrained weights, and the code will be reviewed and confirmed to work, I will also add docstrings. Thanks for the feedback!

aravind-h-v pushed a commit to aravind-h-v/mmsegmentation that referenced this pull request Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add HRViT
4 participants