Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HRViT #1730

Open
lorinczszabolcs opened this issue Jul 1, 2022 · 6 comments · May be fixed by #1736
Open

Add HRViT #1730

lorinczszabolcs opened this issue Jul 1, 2022 · 6 comments · May be fixed by #1736
Assignees
Labels
Algorithm Improvement or addition of new algorithm model Community help wanted Planned feature

Comments

@lorinczszabolcs
Copy link

Describe the feature

Add the model described in "Multi-Scale High-Resolution Vision Transformer for Semantic Segmentation" which is a new vision transformer backbone design for semantic segmentation. It has a multi-branch high-resolution (HR) architecture with enhanced multi-scale representability, surpassing state-of-the-art MiT and CSWin backbones with an average of +1.78 mIoU improvement, 28% parameter saving, and 21% FLOPs reduction on ADE20K and Cityscapes.

Motivation

Recent model that combines the features of HRNet and ViT, achieving good performance while reducing parameters and FLOPs.

Related resources

Official code can be found here.

Additional context
Their implementation already uses mmseg and mmcv, so should be quite straightforward to add support for it.

@MengzhangLI
Copy link
Contributor

Hi, thanks for your issue. It is really a great work, we have noticed it but due to lack of developers, we do not have a clear time schedule to support it.

If you are willing to support it, PR is always welcome and we would review it as soon as possible because PRs from community are high priority for our repo.

Best,

@lorinczszabolcs
Copy link
Author

Sure, I will try in the following days. Probably will need some help on the way, but hopefully we will manage to do it :).

Best,
Szabi

@MengzhangLI
Copy link
Contributor

OK, feel free to contact us when you meet any problems in your PR.

Best,

@lorinczszabolcs
Copy link
Author

Hi,

I have the first version of the implementation, but I am unsure whether it works or how to test it properly, what kind of tests should be written. Should I create a pull request and continue the discussion there? Is it needed to refer to this issue in that pull request somehow? Thanks for all the help, I am looking forward to your feedback.

Best regards,
Szabi

@xiexinch xiexinch added Planned feature Community help wanted Algorithm Improvement or addition of new algorithm model labels Jul 4, 2022
@xiexinch
Copy link
Collaborator

xiexinch commented Jul 4, 2022

Hi @lorinczszabolcs, sorry for the late reply.
When you have finished your draft version, might create a pull request to this repository and attach this issue, we'll review it ASAP.
You might test your code by loading the weights provided by the author, in generally, it might need to convert the keys of weights. Then you might run an evaluation, if the results match the results on paper, that means your code is correct.

@lorinczszabolcs
Copy link
Author

lorinczszabolcs commented Jul 4, 2022

Hi @xiexinch !

Ok, I will create a pull request soon.

Unfortunately the authors didn't provide pretrained weights for now. Would you have the resources to train the networks from scratch and evaluate them that way, maybe also providing pretrained weights after that?

@lorinczszabolcs lorinczszabolcs linked a pull request Jul 4, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Algorithm Improvement or addition of new algorithm model Community help wanted Planned feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants