Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Add URL of Swin pretrained model. #111

Merged
merged 2 commits into from
Mar 14, 2022
Merged

[Fix] Add URL of Swin pretrained model. #111

merged 2 commits into from
Mar 14, 2022

Conversation

jbwang1997
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Add URL of Swin pretrained model.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. The documentation has been modified accordingly, like docstring or example tutorials.

Copy link
Collaborator

@yangxue0827 yangxue0827 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Mar 11, 2022

Codecov Report

Merging #111 (ecfe17b) into dev (077ae5d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #111   +/-   ##
=======================================
  Coverage   28.96%   28.96%           
=======================================
  Files         104      104           
  Lines        6581     6581           
  Branches      985      985           
=======================================
  Hits         1906     1906           
  Misses       4609     4609           
  Partials       66       66           
Flag Coverage Δ
unittests 28.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 077ae5d...ecfe17b. Read the comment docs.

@zytx121
Copy link
Collaborator

zytx121 commented Mar 12, 2022

There are some configurations in configs/kfiou that also use Swin, should we modify them together?

Copy link
Collaborator

@zytx121 zytx121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZwwWayne ZwwWayne merged commit 3ebcee0 into open-mmlab:dev Mar 14, 2022
@zytx121 zytx121 mentioned this pull request Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FileNotFoundError: torch/hub/checkpoints/swin_tiny_patch4_window7_224.pth can not be found.
5 participants