Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix bugs in 3d human pose demo #2413

Merged
merged 2 commits into from
May 31, 2023
Merged

Conversation

LareinaM
Copy link
Collaborator

Motivation

Fix the problem of accidentally detecting multiple bboxes.

Modification

BC-breaking (Optional)

Use cases (Optional)

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit tests to ensure correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

@LareinaM LareinaM marked this pull request as ready for review May 30, 2023 05:52
@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

❗ No coverage uploaded for pull request base (refactor_3d@b3dec97). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head 6c9f5aa differs from pull request most recent head 9d689ad. Consider uploading reports for the commit 9d689ad to get more accurate results

Additional details and impacted files
@@              Coverage Diff               @@
##             refactor_3d    #2413   +/-   ##
==============================================
  Coverage               ?   79.50%           
==============================================
  Files                  ?      244           
  Lines                  ?    14725           
  Branches               ?     2550           
==============================================
  Hits                   ?    11707           
  Misses                 ?     2450           
  Partials               ?      568           
Flag Coverage Δ
unittests 79.50% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Tau-J Tau-J merged commit 2260fa2 into open-mmlab:refactor_3d May 31, 2023
LareinaM added a commit to LareinaM/mmpose that referenced this pull request May 31, 2023
LareinaM added a commit to LareinaM/mmpose that referenced this pull request May 31, 2023
@LareinaM LareinaM deleted the demo3d branch June 26, 2023 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants