Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev 1.x #2299

Merged
merged 2 commits into from
Apr 24, 2023
Merged

Dev 1.x #2299

merged 2 commits into from
Apr 24, 2023

Conversation

Tau-J
Copy link
Collaborator

@Tau-J Tau-J commented Apr 24, 2023

Motivation

Modification

BC-breaking (Optional)

Use cases (Optional)

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit tests to ensure correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.06 ⚠️

Comparison is base (43397c3) 82.06% compared to head (61f3893) 82.01%.

❗ Current head 61f3893 differs from pull request most recent head aa89a7c. Consider uploading reports for the commit aa89a7c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2299      +/-   ##
==========================================
- Coverage   82.06%   82.01%   -0.06%     
==========================================
  Files         232      232              
  Lines       13643    13643              
  Branches     2319     2319              
==========================================
- Hits        11196    11189       -7     
- Misses       1914     1922       +8     
+ Partials      533      532       -1     
Flag Coverage Δ
unittests 82.01% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Tau-J Tau-J merged commit 9dda210 into main Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants