Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix dtype error in StableDiffusion and DreamBooth training #1879

Merged
merged 2 commits into from
May 29, 2023

Conversation

LeoXing1996
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Fix #1867

Modification

As title.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

@LeoXing1996 LeoXing1996 self-assigned this May 29, 2023
@LeoXing1996 LeoXing1996 requested a review from Z-Fran May 29, 2023 05:20
@LeoXing1996 LeoXing1996 force-pushed the leoxing/fix-dreambooth-dtype branch from 7bb0e51 to bd4584e Compare May 29, 2023 05:25
Z-Fran
Z-Fran previously approved these changes May 29, 2023
@codecov
Copy link

codecov bot commented May 29, 2023

Codecov Report

Patch coverage: 42.85% and project coverage change: -0.02 ⚠️

Comparison is base (47a54de) 83.02% compared to head (a0ce951) 83.00%.

❗ Current head a0ce951 differs from pull request most recent head 7e5fc1a. Consider uploading reports for the commit 7e5fc1a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1879      +/-   ##
==========================================
- Coverage   83.02%   83.00%   -0.02%     
==========================================
  Files         411      411              
  Lines       27598    27603       +5     
  Branches     4314     4316       +2     
==========================================
+ Hits        22912    22913       +1     
- Misses       3752     3754       +2     
- Partials      934      936       +2     
Flag Coverage Δ
unittests 83.00% <42.85%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...odels/editors/stable_diffusion/stable_diffusion.py 59.32% <42.85%> (-0.86%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Z-Fran Z-Fran self-requested a review May 29, 2023 06:55
@LeoXing1996 LeoXing1996 merged commit 5f62dee into open-mmlab:main May 29, 2023
@LeoXing1996 LeoXing1996 deleted the leoxing/fix-dreambooth-dtype branch May 29, 2023 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] The dype error in Dreambooth.
2 participants