Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support Textual Inversion #1822

Merged
merged 9 commits into from
Jul 17, 2023

Conversation

LeoXing1996
Copy link
Collaborator

@LeoXing1996 LeoXing1996 commented Apr 26, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Support textual inversion

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

@LeoXing1996 LeoXing1996 self-assigned this Apr 26, 2023
@zengyh1900 zengyh1900 self-requested a review July 5, 2023 11:30
@LeoXing1996 LeoXing1996 force-pushed the leoxing/textual-inversion branch from 0c6dc75 to cfb0990 Compare July 12, 2023 03:38
@LeoXing1996 LeoXing1996 marked this pull request as ready for review July 12, 2023 03:39
@LeoXing1996 LeoXing1996 force-pushed the leoxing/textual-inversion branch from cfb0990 to 1147e45 Compare July 12, 2023 03:40
@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Patch coverage: 27.08% and project coverage change: -0.30 ⚠️

Comparison is base (c089bec) 82.59% compared to head (62b0980) 82.30%.

❗ Current head 62b0980 differs from pull request most recent head 69aa0e0. Consider uploading reports for the commit 69aa0e0 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1822      +/-   ##
==========================================
- Coverage   82.59%   82.30%   -0.30%     
==========================================
  Files         413      416       +3     
  Lines       27811    27954     +143     
  Branches     4366     4375       +9     
==========================================
+ Hits        22971    23008      +37     
- Misses       3895     3997     +102     
- Partials      945      949       +4     
Flag Coverage Δ
unittests 82.30% <27.08%> (-0.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmagic/models/editors/dreambooth/dreambooth.py 62.23% <ø> (ø)
...els/editors/textual_inversion/textual_inversion.py 19.81% <19.81%> (ø)
mmagic/datasets/textual_inversion_dataset.py 40.62% <40.62%> (ø)
mmagic/models/editors/controlnet/controlnet.py 47.36% <50.00%> (-0.46%) ⬇️
mmagic/datasets/__init__.py 100.00% <100.00%> (ø)
mmagic/models/editors/__init__.py 100.00% <100.00%> (ø)
...magic/models/editors/textual_inversion/__init__.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

configs/textual_inversion/README.md Outdated Show resolved Hide resolved
configs/textual_inversion/README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@zengyh1900 zengyh1900 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zengyh1900 zengyh1900 merged commit da03a39 into open-mmlab:main Jul 17, 2023
@LeoXing1996 LeoXing1996 deleted the leoxing/textual-inversion branch July 18, 2023 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants