Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Community] Support Glide Upsampler #1663

Merged
merged 20 commits into from
Jun 1, 2023
Merged

[Community] Support Glide Upsampler #1663

merged 20 commits into from
Jun 1, 2023

Conversation

Taited
Copy link
Contributor

@Taited Taited commented Feb 23, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

Who can help? @ them here!

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

Copy link
Collaborator

@plyfager plyfager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about renaming config like glide_ddim-classifier-free_laion-64-256.py.

@plyfager
Copy link
Collaborator

Thank you for your contribution. I highly recommend you to add this feature to README with the usage code and image results.

@plyfager plyfager changed the title Support Glide Upsampler [Community] Support Glide Upsampler Feb 24, 2023
plyfager
plyfager previously approved these changes Apr 6, 2023
@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (87622b9) 83.00% compared to head (4742e44) 83.01%.

❗ Current head 4742e44 differs from pull request most recent head 535016a. Consider uploading reports for the commit 535016a to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1663   +/-   ##
=======================================
  Coverage   83.00%   83.01%           
=======================================
  Files         411      411           
  Lines       27607    27607           
  Branches     4317     4317           
=======================================
+ Hits        22915    22917    +2     
+ Misses       3756     3755    -1     
+ Partials      936      935    -1     
Flag Coverage Δ
unittests 83.01% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Z-Fran Z-Fran changed the base branch from dev-1.x to main April 26, 2023 07:22
@Z-Fran Z-Fran self-requested a review June 1, 2023 07:15
@Z-Fran Z-Fran merged commit e911724 into open-mmlab:main Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants