-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: initialization and shutdown #179
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! It's a small but important feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super nice addition, this is actually something I already need in the GO SDK.
6ebf587
to
d64f3c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me now! 🙂
Signed-off-by: Todd Baert <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
…for readiness Signed-off-by: Todd Baert <[email protected]>
Co-authored-by: Justin Abrahms <[email protected]> Signed-off-by: Todd Baert <[email protected]>
Co-authored-by: Justin Abrahms <[email protected]> Signed-off-by: Todd Baert <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
Co-authored-by: Jonathan Norris <[email protected]> Signed-off-by: Lukas Reining <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
db43992
to
bdb4ee4
Compare
Signed-off-by: Todd Baert <[email protected]>
Adds initialization and shutdown discussed in DRAFT client PR, and OFEPs. This is a piece of the (too big) draft PR here. The changes are fairly small and non-breaking.
There's a few non-functional changes here (fixes to formatting and minor enhancements to the parser).
Be sure to review
specification.json
for the net changes.Most of this is implemented in the web-sdk already. Some conforming (demo) providers can be found in the playground: