WIP: feat/async #10
Closed
WIP: feat/async #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: AlexsJones <[email protected]>
| fn add_hooks<T>(&self, hooks: T) | ||
| where | ||
| T: hooks::Hooks; | ||
| fn set_evaluation_context(&mut self, eval_ctx: evaluation::EvaluationContext); | ||
| fn evaluation_context(&self) -> evaluation::EvaluationContext; | ||
| async fn connect(&self); |
There was a problem hiding this comment.
Just validating, this is the initialize functionality as per open-feature/spec#179 right?
| pub trait Client<C> | ||
| where | ||
| C: FeatureProvider, | ||
| C: FeatureProvider<C>, |
There was a problem hiding this comment.
I'm just a rust newbie, but this looks like a recursive generic to me. The C in Client<C> is a FeatureProvider. That seems fine with me... But the generic argument to the feature provider is also a C? That part confuses me.
|
Closing due to #15 being merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.