fix: [GO Feature Flag server] Implement ProviderStatus #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Poignant <[email protected]>
beeme1mr
approved these changes
Jul 27, 2023
libs/providers/go-feature-flag/src/lib/go-feature-flag-provider.spec.ts
Outdated
Show resolved
Hide resolved
libs/providers/go-feature-flag/src/lib/go-feature-flag-provider.ts
Outdated
Show resolved
Hide resolved
…r.spec.ts Co-authored-by: Michael Beemer <[email protected]> Signed-off-by: Thomas Poignant <[email protected]>
thomaspoignant
commented
Jul 27, 2023
libs/providers/go-feature-flag/src/lib/go-feature-flag-provider.ts
Outdated
Show resolved
Hide resolved
…r.ts Signed-off-by: Thomas Poignant <[email protected]>
|
Minor comment, according to the spec, I think this indication is missing: |
|
@liran2000 you are totally right, I've opened this PR #505 to fix that. |
Nice catch @liran2000 . We actually missed this in flagd-js as well. I created and issue: #517 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Fixes #489