Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[flagd-server] check if connected before attempting resolution #517

Closed
toddbaert opened this issue Aug 1, 2023 · 1 comment
Closed

[flagd-server] check if connected before attempting resolution #517

toddbaert opened this issue Aug 1, 2023 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@toddbaert
Copy link
Member

Before we try to resolve flag values, we should see if the provider is READY. If not, we should throw the not-ready error. With the current implementation, we'd attempt a gRPC call and then get a "general error".

Please also add the appropriate tests.
@toddbaert toddbaert added enhancement New feature or request good first issue Good for newcomers labels Aug 1, 2023
@toddbaert toddbaert mentioned this issue Aug 1, 2023
Merged
@toddbaert
Copy link
Member Author

This was fixed as part of a separate issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@toddbaert