Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(main): release 1.4.0 #154

Merged
merged 6 commits into from
Jan 23, 2024
Merged

chore(main): release 1.4.0 #154

merged 6 commits into from
Jan 23, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 22, 2023

🤖 I have created a release beep boop

1.4.0 (2024-01-23)

🐛 Bug Fixes

  • Fix ArgumentOutOfRangeException for empty hooks (#187) (950775b)
  • More robust shutdown/cleanup/reset (#188) (a790f78)
  • Remove upper-bound version constraint from SCI (#171) (8f8b661)

✨ New Features

🧹 Chore

  • Add GitHub Actions logger for CI (#174) (c1a189a)
  • add placeholder eventing and shutdown sections (#156) (5dfea29)
  • Add support for GitHub Packages (#173) (26cd5cd)
  • Adding sealed keyword to classes (#191) (1a14f6c)
  • deps: update actions/checkout action to v4 (#144) (90d9d02)
  • deps: update actions/setup-dotnet action to v4 (#162) (0b0bb10)
  • deps: update dependency dotnet-sdk to v7.0.404 (#148) (e8ca1da)
  • deps: update github/codeql-action action to v3 (#163) (c85e93e)
  • fix alt text for NuGet on the readme (2cbdba8)
  • Fix FieldCanBeMadeReadOnly (#183) (18a092a)
  • Fix props to support more than one project (#177) (f47cf07)
  • minor formatting cleanup (#168) (d0c25af)
  • Reduce dependency on MEL -> MELA (#176) (a6062fe)
  • remove duplicate eventing section in readme (1efe09d)
  • remove test sleeps, fix flaky test (#194) (f2b9b03)
  • revert breaking setProvider (#190) (2919c2f)
  • update spec release link (a2f70eb)
  • updated readme for inclusion in the docs (6516866)

📚 Documentation

🔄 Refactoring


This PR was generated with Release Please. See documentation.

@github-actions github-actions bot requested a review from a team as a code owner September 22, 2023 09:40
@github-actions github-actions bot force-pushed the release-please--branches--main branch 6 times, most recently from a043de7 to b8d4d61 Compare October 12, 2023 15:47
@github-actions github-actions bot force-pushed the release-please--branches--main branch from b8d4d61 to e627d7f Compare October 31, 2023 19:31
@github-actions github-actions bot changed the title chore(main): release 1.4.0 chore(main): release 2.0.0 Nov 14, 2023
@github-actions github-actions bot force-pushed the release-please--branches--main branch from e627d7f to 6d2033f Compare November 14, 2023 16:42
@toddbaert
Copy link
Member

If possible, we should release this along with events. This isn't necessary though.

@github-actions github-actions bot force-pushed the release-please--branches--main branch from 6d2033f to bb6e729 Compare December 14, 2023 14:45
@github-actions github-actions bot force-pushed the release-please--branches--main branch 4 times, most recently from 42897af to a1dd4db Compare December 28, 2023 12:45
@github-actions github-actions bot force-pushed the release-please--branches--main branch from a1dd4db to 4f8d267 Compare January 5, 2024 22:05
@github-actions github-actions bot force-pushed the release-please--branches--main branch 5 times, most recently from df3763d to bf9a996 Compare January 16, 2024 20:27
@toddbaert
Copy link
Member

toddbaert commented Jan 16, 2024

@austindrenski This release is substantial, particularly it adds events and init / shutdown. Unfortunately along with your recent changes, there's also a breaking change, though absorbing it should be fairly straightforward.

@lukas-reining
Copy link
Member

lukas-reining commented Jan 17, 2024

I think modifying the signatures to include the cancellation and have the "Async" suffix makes sense, and I do like that it will look more like the .NET standard library, but this is a change that will break every existing provider. If we are going to do this as a breaking change, 2.0 is probably the time.

I think so too, and now might be a good moment to do it.
Cancellation tokens and idiomatic naming makes it feel better to me, and having no cancelation tokens could otherwise even be problematic.

@beeme1mr
Copy link
Member

Another thing to consider is that a provider will need to be updated to leverage events, init, and shutdown. If we think this is a good change, I think now is the time to include it.

@toddbaert toddbaert marked this pull request as draft January 17, 2024 17:19
@github-actions github-actions bot force-pushed the release-please--branches--main branch from bf9a996 to 0d70609 Compare January 17, 2024 18:22
@toddbaert
Copy link
Member

What do you folks think about this?

This PR makes the breaking change here non breaking, by adding a new method instead. This means our pending release will no longer be breaking.

This will allow us to release all the pending .NET work, without merging #184. I like the idea of #184, but I think I'd like us all to take some time to discuss exactly what we expect the cancellationToken to do in all circumstances (what should the SDK do on SDK methods like init()/shutdown()?, and what should providers do?).

I think buys us some without sacrificing too much, and we can release a 2.0.0 in the coming weeks.

Interested to hear the opinion of others.

@github-actions github-actions bot force-pushed the release-please--branches--main branch 5 times, most recently from acf4760 to e46c4ed Compare January 19, 2024 21:32
@github-actions github-actions bot force-pushed the release-please--branches--main branch 2 times, most recently from dff9c8a to 4535422 Compare January 19, 2024 23:26
@github-actions github-actions bot force-pushed the release-please--branches--main branch from 4535422 to 3e7bda4 Compare January 23, 2024 01:53
build/Common.prod.props Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2919c2f) 93.50% compared to head (8d0660b) 93.50%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     open-feature/dotnet-sdk-contrib#154   +/-   ##
=======================================
  Coverage   93.50%   93.50%           
=======================================
  Files          23       23           
  Lines         954      954           
  Branches      105      105           
=======================================
  Hits          892      892           
  Misses         38       38           
  Partials       24       24           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Todd Baert <[email protected]>
@toddbaert toddbaert changed the title chore(main): release 2.0.0 chore(main): release 1.4.0 Jan 23, 2024
@toddbaert toddbaert marked this pull request as ready for review January 23, 2024 02:01
@toddbaert
Copy link
Member

I've amended this: 2.0.0 to 1.4.0, and remove the breaking change section, since we reverted that.

@toddbaert toddbaert merged commit 89d50bc into main Jan 23, 2024
14 checks passed
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants