-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update README.md #155
Conversation
fca13c2
to
417a97a
Compare
Codecov Report
@@ Coverage Diff @@
## main #155 +/- ##
=======================================
Coverage 93.91% 93.91%
=======================================
Files 20 20
Lines 542 542
Branches 39 39
=======================================
Hits 509 509
Misses 20 20
Partials 13 13 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting this together. I left a few comments but overall it looks great.
README.md
Outdated
<!-- The 'github-badges' class is used in the docs --> | ||
<p align="center" class="github-badges"> | ||
<a href="https://github.com/open-feature/spec/tree/v0.6.0"> | ||
<img alt="Specification" src="https://img.shields.io/static/v1?label=specification&message=v0.6.0&color=yellow&style=for-the-badge" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't look like this SDK is v0.6.0 compliment yet. Let's leave it at v0.5.2 until the following issue has been resolved.
Signed-off-by: DaryaYuk <[email protected]>
Signed-off-by: Michael Beemer <[email protected]> Signed-off-by: DaryaYuk <[email protected]>
Co-authored-by: Michael Beemer <[email protected]> Signed-off-by: Darya <[email protected]> Signed-off-by: DaryaYuk <[email protected]>
Co-authored-by: Michael Beemer <[email protected]> Signed-off-by: Darya <[email protected]> Signed-off-by: DaryaYuk <[email protected]>
Co-authored-by: Michael Beemer <[email protected]> Signed-off-by: Darya <[email protected]> Signed-off-by: DaryaYuk <[email protected]>
Co-authored-by: Michael Beemer <[email protected]> Signed-off-by: Darya <[email protected]> Signed-off-by: DaryaYuk <[email protected]>
Signed-off-by: DaryaYuk <[email protected]>
5244538
to
592e516
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Signed-off-by: DaryaYuk <[email protected]>
This PR
Related Issues
Fixes #145
Notes
As far as I understood, the Eventing feature and the Shutdown feature haven't been implemented yet