This repository has been archived by the owner on Nov 5, 2023. It is now read-only.
feat(node): Add Compute Pending Block Rollup CLI Option #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
Closed
merklefruit
reviewed
Jul 31, 2023
Co-authored-by: nicolas <[email protected]>
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a
rollup.compute-pending-blockflag to the node cli as a rollup arg.By default, the pending block is computed using the latest block to preserve tx pool privacy.
This flag allows the node operator to compute the pending block using the tx pool.
Testing
No testing required to keep the diff minimal and consistent with op-geth.
Metadata
Addresses part of paradigmxyz#4004.