Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(op-reth): [Node | CLI] Compute Pending Block #4004

Closed
1 task
refcell opened this issue Jul 31, 2023 · 3 comments
Closed
1 task

feat(op-reth): [Node | CLI] Compute Pending Block #4004

refcell opened this issue Jul 31, 2023 · 3 comments
Labels
A-op-reth Related to Optimism and op-reth C-enhancement New feature or request S-stale This issue/PR is stale and will close with no further activity

Comments

@refcell
Copy link
Contributor

refcell commented Jul 31, 2023 •
edited
Loading

Describe the feature

Diff Category: Node | CLI

Overview

An addition to #3794, op-reth should also support computing the pending block using the tx pool as is done in op-geth.

Where should this feature live?

The CLI flag change should go in the main reth binary, under bin/reth.
The logic should be introduced in ...

Completion Criteria

  • added flag to compute pending block

Related issues

Other CLI Flags: #3794

Additional context

Resources
@refcell refcell added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Jul 31, 2023
@refcell
Copy link
Contributor Author

refcell commented Jul 31, 2023

@mattsse @rkrasiuk flag as label:A-op-reth 👉 👈

@refcell refcell mentioned this issue Jul 31, 2023
Merged
@rkrasiuk rkrasiuk added A-op-reth Related to Optimism and op-reth and removed S-needs-triage This issue needs to be labelled labels Jul 31, 2023
@merklefruit merklefruit mentioned this issue Jul 29, 2023
Closed
3 tasks
@github-actions
Copy link
Contributor

This issue is stale because it has been open for 14 days with no activity.

@github-actions github-actions bot added the S-stale This issue/PR is stale and will close with no further activity label Aug 15, 2023
@refcell
Copy link
Contributor Author

refcell commented Aug 15, 2023

Completed in op-rs#34 ✅

@refcell refcell closed this as completed Aug 15, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-op-reth Related to Optimism and op-reth C-enhancement New feature or request S-stale This issue/PR is stale and will close with no further activity
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@refcell @rkrasiuk