Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update spec to include changes to the echcheck test #297

Merged
merged 7 commits into from
Nov 20, 2024
Merged

Conversation

hellais
Copy link
Member

@hellais hellais commented Nov 7, 2024

Checklist

Description

Please, insert here a more detailed description.

data-formats/df-006-tlshandshake.md Outdated Show resolved Hide resolved
data-formats/df-006-tlshandshake.md Outdated Show resolved Hide resolved
data-formats/df-006-tlshandshake.md Outdated Show resolved Hide resolved
nettests/ts-039-echcheck.md Outdated Show resolved Hide resolved
nettests/ts-039-echcheck.md Outdated Show resolved Hide resolved
nettests/ts-039-echcheck.md Show resolved Hide resolved
nettests/ts-039-echcheck.md Show resolved Hide resolved
nettests/ts-039-echcheck.md Outdated Show resolved Hide resolved
DecFox pushed a commit to ooni/probe-cli that referenced this pull request Nov 20, 2024
)

## Checklist

- [x] I have read the [contribution
guidelines](https://github.com/ooni/probe-cli/blob/master/CONTRIBUTING.md)
- [x] reference issue for this pull request:
ooni/probe#1453
- [x] if you changed anything related to how experiments work and you
need to reflect these changes in the ooni/spec repository, please link
to the related ooni/spec pull request:
ooni/spec#297
- [x] if you changed code inside an experiment, make sure you bump its
version number

## Description

Changes to the ECHCheck experiment.

* Replace default URL with cloudflare-ech.com
* Add support for performing an additional ECH handshake with a
different ClientHelloOuter SNI
* Randomize the order of the handshakes
hellais added a commit to ooni/data that referenced this pull request Nov 20, 2024
…_http_middlebox tables (#100)

* Add support for parsing ech related fields from TLS handshakes
* Add support for parsing ooni_run_link_id
xref: ooni/spec#297
Copy link
Contributor

@DecFox DecFox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hellais hellais merged commit fcbf470 into master Nov 20, 2024
@hellais hellais deleted the echcheck branch November 20, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants