Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using cloudflare-ech.com as the target for the ech test #1658

Merged
merged 4 commits into from
Nov 20, 2024

Conversation

hellais
Copy link
Member

@hellais hellais commented Nov 7, 2024

Checklist

Description

Changes to the ECHCheck experiment.

  • Replace default URL with cloudflare-ech.com
  • Add support for performing an additional ECH handshake with a different ClientHelloOuter SNI
  • Randomize the order of the handshakes

@hellais hellais requested a review from DecFox as a code owner November 7, 2024 13:11
* Update TLSHandshake model to include ECHConfig field
* Update tests
@hellais
Copy link
Member Author

hellais commented Nov 7, 2024

For updates to the spec see: ooni/spec#297

* Add extra handshake that uses a different outer SNI field
Copy link
Contributor

@DecFox DecFox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@DecFox DecFox merged commit e64f736 into master Nov 20, 2024
15 of 18 checks passed
@DecFox DecFox deleted the ech-cloudflare branch November 20, 2024 09:27
hellais added a commit to ooni/spec that referenced this pull request Nov 20, 2024
## Checklist

- [x] I have read the [contribution
guidelines](https://github.com/ooni/spec/blob/master/CONTRIBUTING.md)
- [x] reference issue for this pull request: <!-- add URL here -->
- [x] related ooni/probe-cli pull request:
ooni/probe-cli#1658
- [x] If I changed a spec, I also bumped its version number and/or date

<!-- Location of the issue tracker: https://github.com/ooni/probe -->

## Description

Please, insert here a more detailed description.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants