fix: additional fixes for v5

libs/angular-accelerator/package.json

@@ -15,7 +15,7 @@
     "chart.js": "^4.4.3",
     "d3-scale-chromatic": "^3.1.0",
     "rxjs": "~7.8.1",
-    "primeng": "^17.18.2"
+    "primeng": "^17.18.6"
   },
   "dependencies": {},
   "exports": {

libs/angular-accelerator/src/lib/components/diagram/diagram.component.ts

@@ -39,8 +39,7 @@ export class DiagramComponent implements OnInit, OnChanges {
   @Input() sumKey = 'OCX_DIAGRAM.SUM'
   private _diagramType: DiagramType = DiagramType.PIE
   selectedDiagramType: DiagramLayouts | undefined
-  public chartType: 'bar' | 'line' | 'scatter' | 'bubble' | 'pie' | 'doughnut' | 'polarArea' | 'radar' | undefined =
-    'pie'
+  public chartType: 'bar' | 'line' | 'scatter' | 'bubble' | 'pie' | 'doughnut' | 'polarArea' | 'radar' = 'pie'
   @Input()
   get diagramType(): DiagramType {
     return this._diagramType
@@ -121,7 +120,7 @@ export class DiagramComponent implements OnInit, OnChanges {
 
   private diagramTypeToChartType(
     value: DiagramType
-  ): 'bar' | 'line' | 'scatter' | 'bubble' | 'pie' | 'doughnut' | 'polarArea' | 'radar' | undefined {
+  ): 'bar' | 'line' | 'scatter' | 'bubble' | 'pie' | 'doughnut' | 'polarArea' | 'radar' {
     if (value === DiagramType.PIE) return 'pie'
     else if (value === DiagramType.HORIZONTAL_BAR || value === DiagramType.VERTICAL_BAR) return 'bar'
     return 'pie'

libs/angular-testing/package.json

@@ -3,7 +3,7 @@
   "version": "5.1.3",
   "peerDependencies": {
     "@angular/cdk": "^18.0.5",
-    "primeng": "^17.18.2"
+    "primeng": "^17.18.6"
   },
   "dependencies": {},
   "publishConfig": {

libs/portal-integration-angular/package.json

@@ -22,7 +22,7 @@
     "fast-deep-equal": "^3.1.3",
     "msw": "^2.3.1",
     "rxjs": "~7.8.1",
-    "primeng": "^17.18.2",
+    "primeng": "^17.18.6",
     "zod": "^3.23.8",
     "@ngx-translate/http-loader": "^8.0.0",
     "@angular-architects/module-federation": "^18.0.4"

libs/portal-integration-angular/src/lib/core/components/data-view-controls/data-view-controls.component.html

@@ -8,7 +8,7 @@
     optionLabel="icon"
     (onChange)="viewModeChange($event.value)"
   >
-    <ng-template let-item>
+    <ng-template let-item pTemplate>
       <i [class]="item.icon" [title]="item.title || (item.titleKey | translate)"></i>
     </ng-template>
   </p-selectButton>

libs/portal-integration-angular/src/lib/core/components/data-view-controls/data-view-controls.component.ts

@@ -128,7 +128,7 @@ export class DataViewControlsComponent implements OnInit, OnChanges {
 
   @Output() sortChange: EventEmitter<string> = new EventEmitter()
   @Output() filterChange: EventEmitter<string> = new EventEmitter()
-  @Output() dataViewChange: EventEmitter<string> = new EventEmitter()
+  @Output() dataViewChange: EventEmitter<'list' | 'grid'> = new EventEmitter()
   @Output() sortDirectionChange: EventEmitter<boolean> = new EventEmitter()
   @Output() columnsChange: EventEmitter<string[]> = new EventEmitter()
 
@@ -258,7 +258,7 @@ export class DataViewControlsComponent implements OnInit, OnChanges {
       })
   }
 
-  viewModeChange(event: { icon: PrimeIcon; mode: string }): void {
+  viewModeChange(event: { icon: PrimeIcon; mode: 'list' | 'grid' }): void {
     this.dataViewChange.emit(event.mode)
     this.enableToggleColumnButton(event.mode)
   }

libs/portal-layout-styles/src/styles/primeng/sass/theme/designer/components/menu/_breadcrumb.scss

@@ -4,7 +4,7 @@
   border-radius: var(--border-radius);
   padding: var(--breadcrumb-padding);
 
-  ul {
+  ol {
     li {
       .p-menuitem-link {
         transition: var(--list-item-transition);
@@ -23,7 +23,7 @@
         }
       }
 
-      &.p-breadcrumb-chevron {
+      &.p-menuitem-separator {
         margin: 0 $inlineSpacing 0 $inlineSpacing;
         color: var(--text-secondary-color);
       }

libs/portal-layout-styles/src/styles/primeng/sass/theme/designer/components/menu/_menubar.scss

@@ -79,7 +79,6 @@
 
     .p-menuitem-link-active {
       background: var(--menuitem-active-bg);
-      border-left: 4px solid var(--primary-color);
 
       .p-menuitem-text {
         color: var(--text-color);

libs/portal-layout-styles/src/styles/primeng/sass/theme/designer/components/menu/_panelmenu.scss

@@ -1,6 +1,6 @@
 .p-panelmenu {
   .p-panelmenu-header {
-    > a {
+    .p-panelmenu-header-action {
       padding: var(--accordion-header-padding);
       border: var(--accordion-header-border);
       color: var(--text-color);
@@ -9,7 +9,7 @@
       border-radius: var(--border-radius);
       transition: var(--list-item-transition);
 
-      .p-panelmenu-icon {
+      chevronrighticon, chevrondownicon {
         margin-right: var(--inline-spacing);
       }
 
@@ -69,7 +69,7 @@
       .p-menuitem-link {
         @include menuitem-link();
 
-        .p-panelmenu-icon {
+        chevronrighticon, chevrondownicon {
           margin-right: var(--inline-spacing);
         }
       }
@@ -85,7 +85,7 @@
 
     @if $accordionSpacing == 0 {
       .p-panelmenu-header {
-        > a {
+        .p-panelmenu-header-action {
           border-radius: 0;
         }
       }
@@ -96,7 +96,7 @@
 
       &:not(:first-child) {
         .p-panelmenu-header {
-          > a {
+          .p-panelmenu-header-action {
             border-top: 0 none;
           }
 
@@ -111,7 +111,7 @@
 
       &:first-child {
         .p-panelmenu-header {
-          > a {
+          .p-panelmenu-header-action {
             border-top-right-radius: var(--border-radius);
             border-top-left-radius: var(--border-radius);
           }
@@ -120,7 +120,7 @@
 
       &:last-child {
         .p-panelmenu-header:not(.p-highlight) {
-          > a {
+          .p-panelmenu-header-action {
             border-bottom-right-radius: var(--border-radius);
             border-bottom-left-radius: var(--border-radius);
           }

libs/portal-layout-styles/src/styles/primeng/sass/theme/extensions/_calendar.scss

@@ -18,7 +18,7 @@
     background-color: transparent;
     border: 0 none;
 
-    span {
+    calendaricon {
       color: var(--emphasis-medium);
     }
 

libs/portal-layout-styles/src/styles/primeng/sass/theme/extensions/_panelmenu.scss

@@ -17,7 +17,7 @@
     }
 
     .p-panelmenu-header {
-      .p-panelmenu-icon {
+      chevronrighticon, chevrondownicon {
         order: 1;
         margin-left: auto;
         margin-right: 0;
@@ -32,7 +32,7 @@
       }
 
       &:not(.p-highlight) {
-        .p-panelmenu-header-link {
+        .p-panelmenu-header-action {
           &:focus {
             background: var(--accordion-header-hover-bg);
           }

libs/portal-layout-styles/src/styles/shell/topbar/_topbar_theme.scss

@@ -26,16 +26,18 @@
         border: none;
 
         &.p-menubar .p-menubar-root-list > .p-menuitem {
-          > .p-menuitem-link {
-            .p-menuitem-text,
-            .p-menuitem-icon,
-            .p-submenu-icon {
-              color: var(--topbar-item-text-color);
-            }
-
-            &:not(.p-disabled):hover {
-              background: var(--topbar-item-text-hover-bg-color);
-              transition: background-color var(--transition-duration);
+          > .p-menuitem-content {
+            .p-menuitem-link {
+              .p-menuitem-text,
+              .p-menuitem-icon,
+              .p-submenu-icon {
+                color: var(--topbar-item-text-color);
+              }
+
+              &:not(.p-disabled):hover {
+                background: var(--topbar-item-text-hover-bg-color);
+                transition: background-color var(--transition-duration);
+              }
             }
           }
         }

libs/shell-core/package.json

@@ -12,7 +12,7 @@
     "@onecx/angular-integration-interface": "^5",
     "@onecx/angular-remote-components": "^5",
     "@onecx/portal-integration-angular": "^5",
-    "primeng": "17.18.2"
+    "primeng": "^17.18.6"
   },
   "dependencies": {},
   "type": "commonjs",

package.json

@@ -38,7 +38,7 @@
     "ngx-color": "^9.0.0",
     "primeflex": "^3.3.1",
     "primeicons": "^7.0.0",
-    "primeng": "17.18.2",
+    "primeng": "17.18.6",
     "react": "^18.3.1",
     "react-dom": "^18.3.1",
     "rxjs": "7.8.1",