Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: additional fixes for v5 #331

Merged
merged 14 commits into from
Jul 29, 2024
Merged

fix: additional fixes for v5 #331

merged 14 commits into from
Jul 29, 2024

Conversation

KimFFVII
Copy link
Contributor

@KimFFVII KimFFVII commented Jul 23, 2024 •
edited by markuczy
Loading

fixes:

  • needed to add specific view mode type 'list' | 'grid' because 'string' is not sufficient
  • p-selectButton: pTemplate needs to be added to the ng-template as that is how the current usage looks like currently, or you the name of the icon will also appear in the button
  • breadcrumb: fixed the selectors, because they were changed in primeng and the margin between the items were not there
  • p-calendar: fixed calendar icon color via portal-layout-styles
  • p-menubar
    • removed unused border
    • fixed menubar item text color
  • p-panelmenu
    • fixed header icon selectors
    • fixed menu item selectors

@KimFFVII KimFFVII changed the title fix: add specific type for view mode fix: additional fixes for v5 Jul 24, 2024
@KimFFVII KimFFVII marked this pull request as ready for review July 29, 2024 06:35
@KimFFVII KimFFVII merged commit 4c2088b into onecx:main Jul 29, 2024
4 of 6 checks passed
github-actions bot pushed a commit that referenced this pull request Jul 29, 2024
@semantic-release-bot
chore(release): -v5.1.5 [skip ci]
ee95fd5 
## [5.1.5](v5.1.4...v5.1.5) (2024-07-29)

### Bug Fixes

* additional fixes for v5 ([#331](#331)) ([4c2088b](4c2088b))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SchettlerKoehler SchettlerKoehler SchettlerKoehler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KimFFVII @SchettlerKoehler @markuczy