feat(contracts): add initial stake deposit contract #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinhalliday
commented
Mar 11, 2024
| require(msg.value > 1 ether, "OmniStake: deposit amt too low"); | ||
| require(msg.value < type(uint64).max, "OmniStake: deposit amt too high"); | ||
| emit Deposit(msg.sender, msg.value); | ||
| } |
There was a problem hiding this comment.
Put in some reasonable checks for now. Minimum of 1 ether makes sense - we may want to go higher.
Max can be informed by consensus chain. Went with max uint64, because we use uint64 in most places.
Right now our avs uses uint96 for amounts (because this is what we get from eigen layer).
ttarsi
approved these changes
Mar 11, 2024
Zodomo
added a commit
that referenced
this pull request
Dec 20, 2024
Added _initial_ support for user stake delegation to the `Staking` contract, and updated related Go. I also added support for delegating on behalf of other users. The omni CLI delegate command was only updated for the new delegate function interface, so CLI still only supports self-delegation, for now. It has yet to be determined what contract changes, if any, are necessary for unstaking. This contract should not be upgraded yet until the entire scope is known. issue: #567
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add initial OmniStake contract.
task: https://app.asana.com/0/1206208509925075/1206566996089588