feat(contracts/core): support user stake delegation #2681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zodomo
requested review from
corverroos,
chmllr,
kc1116 and
kevinhalliday
as code owners
corverroos
reviewed
Dec 12, 2024
kevinhalliday
requested changes
Dec 17, 2024
Zodomo
force-pushed
the
zodomo/delegatefor
branch
from
ad596e2 to
1bc71e1
Compare
kevinhalliday
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added initial support for user stake delegation to the
Stakingcontract, and updated related Go. I also added support for delegating on behalf of other users. The omni CLI delegate command was only updated for the new delegate function interface, so CLI still only supports self-delegation, for now.It has yet to be determined what contract changes, if any, are necessary for unstaking. This contract should not be upgraded yet until the entire scope is known.
issue: #567