Skip to content
This repository has been archived by the owner on Mar 30, 2022. It is now read-only.

V3.22.1 boba #9

Open
wants to merge 16 commits into
base: dev
Choose a base branch
from
Open

V3.22.1 boba #9

wants to merge 16 commits into from

Conversation

InoMurko
Copy link

What it solves

Resolves #

How this PR fixes it

How to test it

Analytics changes

Screenshots

InoMurko and others added 15 commits February 4, 2022 19:34
* feat: virtualize collectible list

* fix: Center collectibles

* fix: calculate rows

* fix: remove unnecessary dependency

* fix: add `key`

* fix: switch to `Virtuoso` + remove scrollbar

* fix: use `data` prop

* fix: use window scrollbar + adjust margin

* fix: use container scrollbar

* Fix: add a Loading state for Collectibles (5afe#3701)

* fix: comment + duplicate key warnings

Co-authored-by: Usame Algan <[email protected]>
Co-authored-by: katspaugh <[email protected]>
* fix: clear pending status upon failure

* fix: rename function

* fix: don't throw

* fix: resolve spy

* fix: don't check receipt + set `txId`

* fix: remove `only` from test
* Fix: safeTxGasEstimation race condition

* Fix tests

* Add useAsync tests

* Rm redundant check

* Don't estimate safeTxGas if no txData

* Set baseGas and gasPrice in createTransaction

* Pass safeTxGas to gas limit estimation

* Remove pedning if receipt status false

* Restore getRecommendedNonce

* Fix tests

* Revert pending watcher changes

* Add a warning on tx fail
* fix: clear pending status upon failure

* fix: rename function

* fix: don't throw

* fix: resolve spy

* fix: reject Safe creation if reverted

* fix: don't check receipt + set `txId`

* fix: don't check for reversion on `promiEvent`

* fix: throw `Error` object + adjust comment

* fix: throw `Error` object + adjust comment

* fix: add return
* Feat: add AppStore button in the footer

* Optimize icons with svgo

* Hide footer on Safe Apps

* Pairing referral link
@github-actions
Copy link

CLA Assistant Lite:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


0 out of 3 committers have signed the CLA.
@InoMurko
@sk-enya
@ino Murko
Ino Murko seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger the CLA Action by commenting recheckcla in this Pull Request

@coveralls
Copy link

coveralls commented Mar 25, 2022

Pull Request Test Coverage Report for Build 2040008900

  • 45 of 74 (60.81%) changed or added relevant lines in 16 files are covered.
  • 3 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.1%) to 35.095%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/AppLayout/index.tsx 0 1 0.0%
src/routes/safe/components/Transactions/helpers/TxModalWrapper/index.tsx 1 2 50.0%
src/components/AppstoreButton/index.tsx 0 2 0.0%
src/logic/collectibles/store/selectors/index.ts 0 2 0.0%
src/routes/safe/components/Balances/Collectibles/components/Item.tsx 0 2 0.0%
src/routes/safe/components/Transactions/helpers/TxParametersDetail/index.tsx 2 4 50.0%
src/logic/safe/transactions/gas.ts 0 3 0.0%
src/routes/CreateSafePage/components/SafeCreationProcess.tsx 0 3 0.0%
src/logic/collectibles/sources/Gnosis.ts 0 4 0.0%
src/routes/safe/components/Balances/Collectibles/index.tsx 0 9 0.0%
Files with Coverage Reduction New Missed Lines %
src/logic/safe/store/actions/createTransaction.ts 1 48.03%
src/routes/CreateSafePage/components/SafeCreationProcess.tsx 1 7.46%
src/routes/safe/components/Balances/Collectibles/index.tsx 1 0%
Totals Coverage Status
Change from base Build 2018944630: 0.1%
Covered Lines: 3402
Relevant Lines: 8765

💛 - Coveralls

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants