This repository has been archived by the owner on Mar 30, 2022. It is now read-only.
forked from 5afe/safe-react
-
Notifications
You must be signed in to change notification settings - Fork 1
V3.22.1 boba #9
Open
InoMurko
wants to merge
16
commits into
dev
Choose a base branch
from
v3.22.1-boba
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
V3.22.1 boba #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: virtualize collectible list * fix: Center collectibles * fix: calculate rows * fix: remove unnecessary dependency * fix: add `key` * fix: switch to `Virtuoso` + remove scrollbar * fix: use `data` prop * fix: use window scrollbar + adjust margin * fix: use container scrollbar * Fix: add a Loading state for Collectibles (5afe#3701) * fix: comment + duplicate key warnings Co-authored-by: Usame Algan <[email protected]> Co-authored-by: katspaugh <[email protected]>
* fix: clear pending status upon failure * fix: rename function * fix: don't throw * fix: resolve spy * fix: don't check receipt + set `txId` * fix: remove `only` from test
* Fix: safeTxGasEstimation race condition * Fix tests * Add useAsync tests * Rm redundant check * Don't estimate safeTxGas if no txData * Set baseGas and gasPrice in createTransaction * Pass safeTxGas to gas limit estimation * Remove pedning if receipt status false * Restore getRecommendedNonce * Fix tests * Revert pending watcher changes * Add a warning on tx fail
* fix: clear pending status upon failure * fix: rename function * fix: don't throw * fix: resolve spy * fix: reject Safe creation if reverted * fix: don't check receipt + set `txId` * fix: don't check for reversion on `promiEvent` * fix: throw `Error` object + adjust comment * fix: throw `Error` object + adjust comment * fix: add return
* Feat: add AppStore button in the footer * Optimize icons with svgo * Hide footer on Safe Apps * Pairing referral link
CLA Assistant Lite: I have read the CLA Document and I hereby sign the CLA 0 out of 3 committers have signed the CLA. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Resolves #
How this PR fixes it
How to test it
Analytics changes
Screenshots