fix: reject Safe creation if reverted

[iamacook]

What it solves

Rejected Safe creation transactions.

How this PR fixes it

The transaction receipt returned by the transaction monitor is checked for receipt.status === false to determine if it is reverted. If so, it is rejected.

The deploymentTx itself will throw if it reverts and we therefore not need check it's status.

How to test it

Attempt to create a Safe with a transaction that will revert. If not successful:

The original transaction would throw an error along the lines of "EVM reverted the transaction".
The sped-up transaction would throw an error in the console: "Sped-up tx reverted".

Screenshots

[github-actions]

CLA Assistant Lite All Contributors have signed the CLA.

[github-actions]

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

• Result: ✅ success
• Annotations: 0 total

---

^{Report generated by eslint-plus-action}

[github-actions]

Deployment links

🟠 Rinkeby	⚪ Mainnet	🟣 Polygon	🟡 BSC	⚫ Arbitrum	🟢 Gnosis Chain

[iamacook]

Forgive the over-commits. Seems like GitHub's outage lead to some strange behaviour.

[katspaugh]

Code looks good!
Could you post a screenshot of the creation page when a tx reverts? Thanks!

[iamacook]

Could you post a screenshot of the creation page when a tx reverts? Thanks!

Please see the description.

[usame-algan]

👍

[francovenica]

I'm getting this error by setting a low value gas limit
For this one I set the default 523k gas limit to 123k in the MM popup

[iamacook]

I'm getting this error by setting a low value gas limit For this one I set the default 523k gas limit to 123k in the MM popup

This is as intended. The error object is also logged for the user.

[francovenica]

Ok, looks good to me.