fix: reject Safe creation if reverted (#3692)

* fix: clear pending status upon failure

* fix: rename function

* fix: don't throw

* fix: resolve spy

* fix: reject Safe creation if reverted

* fix: don't check receipt + set `txId`

* fix: don't check for reversion on `promiEvent`

* fix: throw `Error` object + adjust comment

* fix: throw `Error` object + adjust comment

* fix: add return

src/logic/safe/transactions/__tests__/pendingTxMonitor.test.ts

@@ -181,7 +181,7 @@ describe('PendingTxMonitor', () => {
       }
     })
 
-    it('checks each pending tx', async () => {
+    it.only('checks each pending tx', async () => {
       jest.spyOn(store.store, 'getState').mockImplementation(() => ({
         pendingTransactions: {
           '4': {

src/routes/CreateSafePage/components/SafeCreationProcess.tsx

@@ -40,6 +40,7 @@ import { getExplorerInfo, getShortName } from 'src/config'
 import { createSendParams } from 'src/logic/safe/transactions/gas'
 import { currentChainId } from 'src/logic/config/store/selectors'
 import PrefixedEthHashInfo from 'src/components/PrefixedEthHashInfo'
+import { didTxRevert } from 'src/logic/safe/store/actions/transactions/utils/transactionHelpers'
 
 export const InlinePrefixedEthHashInfo = styled(PrefixedEthHashInfo)`
   display: inline-flex;
@@ -136,6 +137,13 @@ const createNewSafe = (userAddress: string, onHash: (hash: string) => void): Pro
         // Monitor the latest block to find a potential speed-up tx
         txMonitor({ sender: userAddress, hash: txHash, data: deploymentTx.encodeABI() })
           .then((txReceipt) => {
+            // txMonitor returns the txReceipt from `getTransactionReceipt` which doesn't throw
+            // if it was reverted. We must check the status of the receipt manually.
+            if (didTxRevert(txReceipt)) {
+              reject(new Error('Sped-up tx reverted'))
+              return
+            }
+
             console.log('Sped-up tx mined:', txReceipt)
             resolve(txReceipt)
           })
@@ -148,6 +156,7 @@ const createNewSafe = (userAddress: string, onHash: (hash: string) => void): Pro
         resolve(txReceipt)
       })
       .catch((error) => {
+        // `deploymentTx` will throw if the transaction was reverted
         reject(parseError(error))
       })
   })