-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use versioneer for tagging (Fix #154) #156
Conversation
Move to the use of https://github.com/python-versioneer/python-versioneer for defining a version from the current tag. This also removes the need to use bump2version, therefore releases can be handled completely from the GH UI.
for more information, see https://pre-commit.ci
Versioneer looks nice. So the release steps (currently https://ome-contributing.readthedocs.io/en/latest/python-development.html) are now:
|
struggling with pre-commit here. options are:
|
Is it a workflow that you see rolling out to other repositories when ready? |
Not sure. Happy to discuss. The two big benefits are:
If you need to have version strings updated anywhere else, though, this won't do it for you. |
More like either:
Or:
|
Pushed another attempt. Apparently the |
Discussing with @will-moore and @jburel, this looks to be working. You can also test locally with:
|
One key difference is that we now need to have 2 Python files included in the project tree |
At least for So what's the next step here? |
I'm needing to use this PR now to continue to export from IDR, and it's working. I think @jburel was just wanting some mention of the versioneer changes in the README? |
For |
Following from #157 (comment), @jburel, you're saying that you want me to introduce a dependency on the versioneer library here? You can find out more about the "experimental build-time dependency mode" here: https://github.com/python-versioneer/python-versioneer?tab=readme-ov-file#build-time-dependency-mode |
Closing in favor of #159 for the moment. |
Move to the use of https://github.com/python-versioneer/python-versioneer for defining a version from the current tag. This also removes the need to use bump2version, therefore releases can be handled completely from the GH UI.
cc: @will-moore