Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pre-commit.ci] pre-commit autoupdate #218

Merged
merged 3 commits into from
Aug 27, 2022
Merged

Conversation

pre-commit-ci[bot]
Copy link
Contributor

@pre-commit-ci pre-commit-ci bot commented Aug 1, 2022

@will-moore
Copy link
Member

See globality-corp/flake8-logging-format#35
Looks like there's a fix, but not release yet

@joshmoore
Copy link
Member

Thanks, @will-moore. Let's hope this gets updated soon.

updates:
- [github.com/asottile/pyupgrade: v2.37.2 → v2.37.3](asottile/pyupgrade@v2.37.2...v2.37.3)
- [github.com/PyCQA/flake8: 4.0.1 → 5.0.4](PyCQA/flake8@4.0.1...5.0.4)
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 37d2406 to 2fd0411 Compare August 8, 2022 22:23
@sbesson
Copy link
Member

sbesson commented Aug 9, 2022

With the introduction of the new flake8 logging checks, 664cbfd is similar to ome/napari-ome-zarr@d6b48bb and adjusts the logging statements to avoid the usage of f-strings and %. In addition, 4feb066 addresses the G200 warnings by making more systematic usages of logging.exception.

These changes might impact open pull requests, notably the large ongoing work on dask support in #192. Integrating it will require some coordination and likely conflict resolution either way.

@sbesson sbesson requested a review from will-moore August 9, 2022 10:12
@codecov
Copy link

codecov bot commented Aug 9, 2022

Codecov Report

Merging #218 (4feb066) into master (4e944b2) will increase coverage by 0.06%.
The diff coverage is 60.41%.

@@            Coverage Diff             @@
##           master     #218      +/-   ##
==========================================
+ Coverage   83.91%   83.97%   +0.06%     
==========================================
  Files          12       12              
  Lines        1380     1379       -1     
==========================================
  Hits         1158     1158              
+ Misses        222      221       -1     
Impacted Files Coverage Δ
ome_zarr/reader.py 85.26% <39.13%> (+0.22%) ⬆️
ome_zarr/io.py 83.76% <44.44%> (ø)
ome_zarr/format.py 97.59% <100.00%> (ø)
ome_zarr/utils.py 90.80% <100.00%> (ø)
ome_zarr/writer.py 96.27% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us.

@sbesson sbesson requested a review from joshmoore August 9, 2022 10:12
@sbesson
Copy link
Member

sbesson commented Aug 27, 2022

Merging as it looks like the precommit CI is failing on a subset of these errors on the HEAD of this repository

@sbesson sbesson merged commit ba03145 into master Aug 27, 2022
@joshmoore joshmoore deleted the pre-commit-ci-update-config branch September 5, 2022 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants