Use logging.exception to fix G200

ome · Aug 9, 2022 · 4feb066 · 4feb066
1 parent 664cbfd
commit 4feb066
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 13 deletions.
diff --git a/ome_zarr/io.py b/ome_zarr/io.py
@@ -155,8 +155,8 @@ def get_json(self, subpath: str) -> JSONDict:
         except KeyError:
             LOGGER.debug("JSON not found: %s", subpath)
             return {}
-        except Exception as e:
-            LOGGER.exception("%s", e)
+        except Exception:
+            LOGGER.exception("Error while loading JSON")
             return {}
 
     def parts(self) -> List[str]:
@@ -190,7 +190,7 @@ def parse_url(
             return None
         else:
             return loc
-    except Exception as e:
-        LOGGER.warning("exception on parsing: %s (stacktrace at DEBUG)", e)
+    except Exception:
+        LOGGER.exception("exception on parsing (stacktrace at DEBUG)")
         LOGGER.debug("stacktrace:", exc_info=True)
         return None
diff --git a/ome_zarr/reader.py b/ome_zarr/reader.py
@@ -240,8 +240,8 @@ def __init__(self, node: Node) -> None:
                     else:
                         raise Exception("not bool or int")
 
-                except Exception as e:
-                    LOGGER.error("invalid color - %s: %s", color, e)
+                except Exception:
+                    LOGGER.exception("invalid color - %s", color)
 
         properties: Dict[int, Dict[str, str]] = {}
         props_list = image_label.get("properties", [])
@@ -296,8 +296,8 @@ def __init__(self, node: Node) -> None:
             if any(trans is not None for trans in transformations):
                 node.metadata["coordinateTransformations"] = transformations
             LOGGER.info("datasets %s", datasets)
-        except Exception as e:
-            LOGGER.error("failed to parse multiscale metadata: %s", e)
+        except Exception:
+            LOGGER.exception("Failed to parse multiscale metadata")
             return  # EARLY EXIT
 
         for resolution in self.datasets:
@@ -392,8 +392,8 @@ def __init__(self, node: Node) -> None:
             node.metadata["contrast_limits"] = contrast_limits
             node.metadata["colormap"] = colormaps
 
-        except Exception as e:
-            LOGGER.error("failed to parse metadata: %s", e)
+        except Exception:
+            LOGGER.exception("Failed to parse metadata")
 
 
 class Well(Spec):
@@ -546,9 +546,8 @@ def get_tile(tile_name: str) -> np.ndarray:
 
             try:
                 data = self.zarr.load(path)
-            except ValueError as e:
-                LOGGER.error("Failed to load %s", path)
-                LOGGER.debug("%s", e)
+            except ValueError:
+                LOGGER.exception("Failed to load %s", path)
                 data = np.zeros(tile_shape, dtype=self.numpy_type)
             return data