Add tests on Python 3.12 #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -25,7 +25,7 @@ jobs: | |||
| strategy: | |||
| matrix: | |||
| platform: [ubuntu-latest, windows-latest, macos-latest] | |||
| python-version: ["3.8", "3.9", "3.10", "3.11"] | |||
| python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"] | |||
There was a problem hiding this comment.
Suggested change
| python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"] | |
| python-version: ["3.9", "3.10", "3.11", "3.12"] |
napari no longer supports 3.8 (and soon 3.9), so I suggest dropping it here to keep the same number of CI runs
| @@ -18,6 +18,7 @@ classifiers = | |||
| Programming Language :: Python :: 3.9 | |||
There was a problem hiding this comment.
Can't suggest, but I suggest deleting line 17, Python 3.8
| @@ -1,13 +1,14 @@ | |||
| # For more information about tox, see https://tox.readthedocs.io/en/latest/ | |||
| [tox] | |||
| envlist = py{38,39,310,311}-{linux,macos,windows} | |||
| envlist = py{38,39,310,311,312}-{linux,macos,windows} | |||
There was a problem hiding this comment.
Suggested change
| envlist = py{38,39,310,311,312}-{linux,macos,windows} | |
| envlist = py{39,310,311,312}-{linux,macos,windows} |
| @@ -1,13 +1,14 @@ | |||
| # For more information about tox, see https://tox.readthedocs.io/en/latest/ | |||
| [tox] | |||
| envlist = py{38,39,310,311}-{linux,macos,windows} | |||
| envlist = py{38,39,310,311,312}-{linux,macos,windows} | |||
|
|
|||
| [gh-actions] | |||
| python = | |||
| 3.8: py38 | |||
There was a problem hiding this comment.
Suggested change
| 3.8: py38 |
|
I'd rather keep this PR simple, and remove Python 3.8 in another PR. |
|
Thanks, I am currently removing Python 3.8 from various repository and updating the submission to pypi (see #120) |
|
🎉 thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.