Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use build instead of sdist #120

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Use build instead of sdist #120

wants to merge 2 commits into from

Conversation

jburel
Copy link
Member

@jburel jburel commented Nov 20, 2024

sdist produces a package name containing with - instead of _, triggering a deprecation warning (see PEP 625).

@jburel jburel mentioned this pull request Nov 21, 2024
Merged
@jburel jburel requested a review from joshmoore November 24, 2024 21:34
@jburel
Copy link
Member Author

jburel commented Dec 3, 2024

@joshmoore Could you please have a look? Thanks

joshmoore
joshmoore approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@joshmoore joshmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as setuptools_scm is still being picked up from setup.cfg (as I would expect), this looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psobolewskiPhD psobolewskiPhD psobolewskiPhD left review comments

@joshmoore joshmoore joshmoore approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jburel @joshmoore @psobolewskiPhD