Add a few options for working with CZI files that have multiple scenes #3681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If enabled, stores upper-left pixel coordinate for each scene relative to entire canvas.
|
This PR has had no impact on existing builds and tests, all repo tests have continued to pass. Both without this PR or with this PR and the default options, the width and height values are as such: With this PR and the new Both without this PR or with this PR and the default options, the With this PR and the new Using the combination of both options together also works as expected |
|
Confirmed with Zen that the above values are correct, PR is good for inclusion in 6.7.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting
zeissczi.relative_positionsto true will change thePositionXandPositionYvalues stored in OME-XML to the pixel position instead of the absolute physical stage position. Settingzeissczi.trim_dimensionsto true will use the pixel block metadata to trim XY dimensions to match what ZEN reports.Default behavior shouldn't change, so tests should continue to pass. Comparing e.g.
zeiss-czi/zeiss/jpeg-xr/*2scenes*.cziin ZEN and with each combination of options should be enough to test. The idea is that with both options set to true, it would be easier to place the images on a canvas just like ZEN does when theScenebox is unchecked. As far as I know, ZEN doesn't report the sizes for each individual scene, you have to actually mouse over the upper left and lower right corners to calculate the position, width, and height.